From ea8665c2e22e22de13c87d3a00be7357cc0f4ec5 Mon Sep 17 00:00:00 2001 From: David Schulz Date: Fri, 4 Dec 2015 14:36:04 +0100 Subject: [PATCH] CdbExtension: Make sure watches group is initialized. This fixes a crash that occurs when a debugger was started without an active watch and a watch were added afterwards. Change-Id: I0219a750bae7b433240b22f99b2e8fd8655ca331 Reviewed-by: Christian Stenger --- .../qtcreatorcdbext/qtcreatorcdbextension.cpp | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/libs/qtcreatorcdbext/qtcreatorcdbextension.cpp b/src/libs/qtcreatorcdbext/qtcreatorcdbextension.cpp index 5fce7aa9892..0f0aea6e07d 100644 --- a/src/libs/qtcreatorcdbext/qtcreatorcdbextension.cpp +++ b/src/libs/qtcreatorcdbext/qtcreatorcdbextension.cpp @@ -513,14 +513,16 @@ static std::string commandLocals(ExtensionCommandContext &commandExtCtx,PCSTR ar if (watchSynchronization) { watchesSymbolGroup = 0; extCtx.discardWatchesSymbolGroup(); - if (!watcherInameExpressionMap.empty()) { - // Force group into existence - watchesSymbolGroup = extCtx.watchesSymbolGroup(commandExtCtx.symbols(), errorMessage); - if (!watchesSymbolGroup || !watchesSymbolGroup->synchronize(commandExtCtx.symbols(), - watcherInameExpressionMap, - errorMessage)) { - return std::string(); - } + } + + if (watchesSymbolGroup == 0 + && (!watcherInameExpressionMap.empty() || WatchesSymbolGroup::isWatchIname(iname))) { + // Force group into existence + watchesSymbolGroup = extCtx.watchesSymbolGroup(commandExtCtx.symbols(), errorMessage); + if (!watchesSymbolGroup || !watchesSymbolGroup->synchronize(commandExtCtx.symbols(), + watcherInameExpressionMap, + errorMessage)) { + return std::string(); } }