VCS: Remove "Prompt to submit" settings

Task-number: QTCREATORBUG-22233
Change-Id: Ifbfd738281066af7913357ff9e2466a6c983452c
Reviewed-by: André Hartmann <aha_1980@gmx.de>

src/plugins/cvs/cvsplugin.cpp

@@ -726,11 +726,8 @@ bool CvsPluginPrivate::submitEditorAboutToClose()
 
     // Prompt user. Force a prompt unless submit was actually invoked (that
     // is, the editor was closed or shutdown).
-    const VcsBaseSubmitEditor::PromptSubmitResult answer = editor->promptSubmit(
-                this, nullptr,
-                !m_submitActionTriggered,
-                true,
-                &m_settings.promptOnSubmit);
+    const VcsBaseSubmitEditor::PromptSubmitResult answer =
+            editor->promptSubmit(this, !m_submitActionTriggered);
     m_submitActionTriggered = false;
     switch (answer) {
     case VcsBaseSubmitEditor::SubmitCanceled:

src/plugins/cvs/cvssettings.cpp

@@ -96,7 +96,6 @@ CvsSettingsPage::CvsSettingsPage(CvsSettings *settings)
                         s.timeout,
                         s.diffOptions,
                     },
-                    s.promptOnSubmit,
                     s.describeByCommitId,
                 }
             },