From eab76c5007c1d4aba8ee72f3493cc2fa6c292378 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Fri, 13 Jan 2023 00:31:25 +0100 Subject: [PATCH] Differ: Initialize EqualityData fields by default The last two fields were not initialized before. Make the struct internal in function. Change-Id: Ib416aa26b17626ec55d76cb944ff9d763beaa190 Reviewed-by: Reviewed-by: Orgad Shaneh --- src/libs/utils/differ.cpp | 20 +++++++++----------- 1 file changed, 9 insertions(+), 11 deletions(-) diff --git a/src/libs/utils/differ.cpp b/src/libs/utils/differ.cpp index 993f7943e93..d1b885be91d 100644 --- a/src/libs/utils/differ.cpp +++ b/src/libs/utils/differ.cpp @@ -1356,18 +1356,17 @@ QList Differ::merge(const QList &diffList) return squashedDiffList; } -struct EqualityData -{ - int equalityIndex; - int textCount; - int deletesBefore; - int insertsBefore; - int deletesAfter; - int insertsAfter; -}; - QList Differ::cleanupSemantics(const QList &diffList) { + struct EqualityData + { + int equalityIndex = 0; + int textCount = 0; + int deletesBefore = 0; + int insertsBefore = 0; + int deletesAfter = 0; + int insertsAfter = 0; + }; int deletes = 0; int inserts = 0; // equality index, equality data @@ -1390,7 +1389,6 @@ QList Differ::cleanupSemantics(const QList &diffList) data.deletesBefore = deletes; data.insertsBefore = inserts; equalities.append(data); - deletes = 0; inserts = 0; }