feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

KitInformation: Make defaultValue take a const Kit *

Browse Source 
There is no reason not to.

Change-Id: I4accb0b690173d93ad6f4c9dd0bce66d8de75faa
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2016-02-04 17:49:28 +01:00
parent 7f61a590ab
commit eafb667066
15 changed files with 25 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/android/androidgdbserverkitinformation.cpp
View File

@@ -53,7 +53,7 @@ AndroidGdbServerKitInformation::AndroidGdbServerKitInformation()
setPriority(27999); // Just one less than Debugger!
}
QVariant AndroidGdbServerKitInformation::defaultValue(Kit *kit) const
QVariant AndroidGdbServerKitInformation::defaultValue(const Kit *kit) const
{
return autoDetect(kit).toString();
}
@@ -100,7 +100,7 @@ void AndroidGdbServerKitInformation::setGdbSever(Kit *kit, const FileName &gdbSe
kit->setValue(AndroidGdbServerKitInformation::id(), gdbServerCommand.toString());
}
FileName AndroidGdbServerKitInformation::autoDetect(Kit *kit)
FileName AndroidGdbServerKitInformation::autoDetect(const Kit *kit)
{
ToolChain *tc = ToolChainKitInformation::toolChain(kit);
if (!tc || tc->typeId() != Constants::ANDROID_TOOLCHAIN_ID)

4
src/plugins/android/androidgdbserverkitinformation.h
View File

@@ -68,7 +68,7 @@ class AndroidGdbServerKitInformation : public ProjectExplorer::KitInformation
public:
AndroidGdbServerKitInformation();
QVariant defaultValue(ProjectExplorer::Kit *) const override;
QVariant defaultValue(const ProjectExplorer::Kit *) const override;
QList<ProjectExplorer::Task> validate(const ProjectExplorer::Kit *) const override;
@@ -80,7 +80,7 @@ public:
static bool isAndroidKit(const ProjectExplorer::Kit *kit);
static Utils::FileName gdbServer(const ProjectExplorer::Kit *kit);
static void setGdbSever(ProjectExplorer::Kit *kit, const Utils::FileName &gdbServerCommand);
static Utils::FileName autoDetect(ProjectExplorer::Kit *kit);
static Utils::FileName autoDetect(const ProjectExplorer::Kit *kit);
};
} // namespace Internal