feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

KitInformation: Make defaultValue take a const Kit *

Browse Source 
There is no reason not to.

Change-Id: I4accb0b690173d93ad6f4c9dd0bce66d8de75faa
Reviewed-by: Niels Weber <niels.weber@theqtcompany.com>
This commit is contained in:
Tobias Hunger
2016-02-04 17:49:28 +01:00
parent 7f61a590ab
commit eafb667066
15 changed files with 25 additions and 26 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakekitinformation.cpp
View File

@@ -91,7 +91,7 @@ Core::Id CMakeKitInformation::defaultValue()
return Core::Id();
}
QVariant CMakeKitInformation::defaultValue(Kit *) const
QVariant CMakeKitInformation::defaultValue(const Kit *) const
{
return defaultValue().toSetting();
}

3
src/plugins/cmakeprojectmanager/cmakekitinformation.h
View File

@@ -46,7 +46,7 @@ public:
static Core::Id defaultValue();
// KitInformation interface
QVariant defaultValue(ProjectExplorer::Kit *) const override;
QVariant defaultValue(const ProjectExplorer::Kit *k) const override;
QList<ProjectExplorer::Task> validate(const ProjectExplorer::Kit *k) const override;
void setup(ProjectExplorer::Kit *k) override;
void fix(ProjectExplorer::Kit *k) override;
@@ -55,4 +55,3 @@ public:
};
} // namespace CMakeProjectManager

2
src/plugins/cmakeprojectmanager/cmakepreloadcachekitinformation.cpp
View File

@@ -51,7 +51,7 @@ Core::Id CMakePreloadCacheKitInformation::id()
return "CMakeProjectManager.CMakePreloadCacheKitInformation";
}
QVariant CMakePreloadCacheKitInformation::defaultValue(Kit *) const
QVariant CMakePreloadCacheKitInformation::defaultValue(const Kit *) const
{
return QString();
}

2
src/plugins/cmakeprojectmanager/cmakepreloadcachekitinformation.h
View File

@@ -40,7 +40,7 @@ public:
static Core::Id id();
// KitInformation interface
QVariant defaultValue(ProjectExplorer::Kit *) const override;
QVariant defaultValue(const ProjectExplorer::Kit *) const override;
QList<ProjectExplorer::Task> validate(const ProjectExplorer::Kit *k) const override;
void setup(ProjectExplorer::Kit *k) override;
void fix(ProjectExplorer::Kit *k) override;