From eb4c101f9b345c032c732edf58f5447c35f0f678 Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Mon, 9 Dec 2013 12:23:23 +0100 Subject: [PATCH] Use dataChanged() implementation from abstract timeline model No need to repeat the same code multiple times. Change-Id: Ibe6865458c7ae47cc32f03cdc493ada320def584 Reviewed-by: Kai Koehne --- .../qmlprofilerextension/pixmapcachemodel.cpp | 14 -------------- plugins/qmlprofilerextension/pixmapcachemodel.h | 9 --------- .../scenegraphtimelinemodel.cpp | 17 ----------------- .../scenegraphtimelinemodel.h | 9 --------- 4 files changed, 49 deletions(-) diff --git a/plugins/qmlprofilerextension/pixmapcachemodel.cpp b/plugins/qmlprofilerextension/pixmapcachemodel.cpp index ff77f8f9623..f4168c83401 100644 --- a/plugins/qmlprofilerextension/pixmapcachemodel.cpp +++ b/plugins/qmlprofilerextension/pixmapcachemodel.cpp @@ -485,20 +485,6 @@ void PixmapCacheModel::clear() m_modelManager->modelProxyCountUpdated(m_modelId, 0, 1); } -void PixmapCacheModel::dataChanged() -{ - if (m_modelManager->state() == QmlProfilerDataState::ProcessingData) - loadData(); - - if (m_modelManager->state() == QmlProfilerDataState::Empty) - clear(); - - emit stateChanged(); - emit dataAvailable(); - emit emptyChanged(); - emit expandedChanged(); -} - void PixmapCacheModel::PixmapCacheModelPrivate::computeCacheSizes() { minCacheSize = -1; diff --git a/plugins/qmlprofilerextension/pixmapcachemodel.h b/plugins/qmlprofilerextension/pixmapcachemodel.h index 8ac8d42218c..d3ec01db3a1 100644 --- a/plugins/qmlprofilerextension/pixmapcachemodel.h +++ b/plugins/qmlprofilerextension/pixmapcachemodel.h @@ -103,15 +103,6 @@ public: void loadData(); void clear(); -//signals: -// void countChanged(); -// void dataAvailable(); -// void stateChanged(); -// void emptyChanged(); -// void expandedChanged(); - -protected slots: - void dataChanged(); private: class PixmapCacheModelPrivate; diff --git a/plugins/qmlprofilerextension/scenegraphtimelinemodel.cpp b/plugins/qmlprofilerextension/scenegraphtimelinemodel.cpp index a7100fa61e8..bfd9613091b 100644 --- a/plugins/qmlprofilerextension/scenegraphtimelinemodel.cpp +++ b/plugins/qmlprofilerextension/scenegraphtimelinemodel.cpp @@ -428,22 +428,5 @@ void SceneGraphTimelineModel::clear() m_modelManager->modelProxyCountUpdated(m_modelId, 0, 1); } -void SceneGraphTimelineModel::dataChanged() -{ - if (m_modelManager->state() == QmlProfilerDataState::ProcessingData) - loadData(); - - if (m_modelManager->state() == QmlProfilerDataState::Empty) - clear(); - - emit stateChanged(); - emit dataAvailable(); - emit emptyChanged(); - emit expandedChanged(); -} - - - - } // namespace Internal } // namespace QmlProfilerExtension diff --git a/plugins/qmlprofilerextension/scenegraphtimelinemodel.h b/plugins/qmlprofilerextension/scenegraphtimelinemodel.h index 299eea5b762..1f283af290e 100644 --- a/plugins/qmlprofilerextension/scenegraphtimelinemodel.h +++ b/plugins/qmlprofilerextension/scenegraphtimelinemodel.h @@ -89,15 +89,6 @@ public: void loadData(); void clear(); -//signals: -// void countChanged(); -// void dataAvailable(); -// void stateChanged(); -// void emptyChanged(); -// void expandedChanged(); - -protected slots: - void dataChanged(); private: class SceneGraphTimelineModelPrivate;