feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

EditorManager: Use interface directly instead of going through ICore

Browse Source 
In the majority of cases we were doing that anyways, having two
ways is just needlessly confusing.

Change-Id: Ied362a702c23beee528368d74df1f2aabe5807f8
Reviewed-by: Tobias Hunger <tobias.hunger@digia.com>
This commit is contained in:
hjk
2013-08-29 17:17:24 +02:00
parent 4a24df38a3
commit eb724f3772
29 changed files with 76 additions and 108 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -311,7 +311,7 @@ void CallgrindToolPrivate::selectFunction(const Function *func)
if (QFile::exists(func->file())) {
///TODO: custom position support?
int line = func->lineNumber();
Core::EditorManager::openEditorAt(func->file(), qMax(line, 0));
EditorManager::openEditorAt(func->file(), qMax(line, 0));
}
}
@@ -493,7 +493,7 @@ CallgrindTool::CallgrindTool(QObject *parent)
d = new CallgrindToolPrivate(this);
setObjectName(QLatin1String("CallgrindTool"));
connect(Core::ICore::editorManager(), SIGNAL(editorOpened(Core::IEditor*)),
connect(EditorManager::instance(), SIGNAL(editorOpened(Core::IEditor*)),
d, SLOT(editorOpened(Core::IEditor*)));
}
@@ -846,7 +846,7 @@ void CallgrindToolPrivate::showParserResults(const ParseData *data)
AnalyzerManager::showStatusMessage(msg);
}
void CallgrindToolPrivate::editorOpened(Core::IEditor *editor)
void CallgrindToolPrivate::editorOpened(IEditor *editor)
{
TextEditor::ITextEditor *textEditor = qobject_cast<TextEditor::ITextEditor *>(editor);
if (!textEditor)