diff --git a/src/libs/timeline/timelinemodel.cpp b/src/libs/timeline/timelinemodel.cpp index c28ca789639..63ea7ce1620 100644 --- a/src/libs/timeline/timelinemodel.cpp +++ b/src/libs/timeline/timelinemodel.cpp @@ -375,14 +375,6 @@ bool TimelineModel::handlesTypeId(int typeIndex) const return false; } -int TimelineModel::selectionIdForLocation(const QString &filename, int line, int column) const -{ - Q_UNUSED(filename); - Q_UNUSED(line); - Q_UNUSED(column); - return -1; -} - float TimelineModel::relativeHeight(int index) const { Q_UNUSED(index); diff --git a/src/libs/timeline/timelinemodel.h b/src/libs/timeline/timelinemodel.h index dd9b6701a78..c525281510e 100644 --- a/src/libs/timeline/timelinemodel.h +++ b/src/libs/timeline/timelinemodel.h @@ -99,8 +99,6 @@ public: Q_INVOKABLE virtual QVariantMap location(int index) const; Q_INVOKABLE virtual int typeId(int index) const; Q_INVOKABLE virtual bool handlesTypeId(int typeId) const; - Q_INVOKABLE virtual int selectionIdForLocation(const QString &filename, int line, - int column) const; Q_INVOKABLE virtual float relativeHeight(int index) const; Q_INVOKABLE virtual int rowMinValue(int rowNumber) const; Q_INVOKABLE virtual int rowMaxValue(int rowNumber) const; diff --git a/src/plugins/qmlprofiler/qmlprofilerrangemodel.cpp b/src/plugins/qmlprofiler/qmlprofilerrangemodel.cpp index 4c174dbc74d..085dd49fde5 100644 --- a/src/plugins/qmlprofiler/qmlprofilerrangemodel.cpp +++ b/src/plugins/qmlprofiler/qmlprofilerrangemodel.cpp @@ -227,21 +227,6 @@ int QmlProfilerRangeModel::typeId(int index) const return selectionId(index); } -int QmlProfilerRangeModel::selectionIdForLocation(const QString &filename, int line, int column) const -{ - // if this is called from v8 view, we don't have the column number, it will be -1 - const QVector &types = modelManager()->qmlModel()->eventTypes(); - for (int i = 1; i < expandedRowCount(); ++i) { - int typeId = m_expandedRowTypes[i]; - const QmlEventType &eventData = types[typeId]; - if (eventData.location.filename == filename && - eventData.location.line == line && - (column == -1 || eventData.location.column == column)) - return typeId; - } - return -1; -} - QList QmlProfilerRangeModel::supportedRenderPasses() const { if (supportsBindingLoops()) { diff --git a/src/plugins/qmlprofiler/qmlprofilerrangemodel.h b/src/plugins/qmlprofiler/qmlprofilerrangemodel.h index cfc68bf998e..3eb281ef8d5 100644 --- a/src/plugins/qmlprofiler/qmlprofilerrangemodel.h +++ b/src/plugins/qmlprofiler/qmlprofilerrangemodel.h @@ -69,7 +69,6 @@ public: QVariantMap location(int index) const override; int typeId(int index) const override; - int selectionIdForLocation(const QString &filename, int line, int column) const override; virtual QList supportedRenderPasses() const override; diff --git a/tests/auto/timeline/timelinemodel/tst_timelinemodel.cpp b/tests/auto/timeline/timelinemodel/tst_timelinemodel.cpp index 49a56e6a83c..d317169e18a 100644 --- a/tests/auto/timeline/timelinemodel/tst_timelinemodel.cpp +++ b/tests/auto/timeline/timelinemodel/tst_timelinemodel.cpp @@ -370,7 +370,6 @@ void tst_TimelineModel::defaultValues() Timeline::TimelineModel dummy(12); QCOMPARE(dummy.location(0), QVariantMap()); QCOMPARE(dummy.handlesTypeId(0), false); - QCOMPARE(dummy.selectionIdForLocation(QString(), 0, 0), -1); QCOMPARE(dummy.relativeHeight(0), 1.0); QCOMPARE(dummy.rowMinValue(0), 0); QCOMPARE(dummy.rowMaxValue(0), 0);