diff --git a/src/plugins/android/androidconfigurations.cpp b/src/plugins/android/androidconfigurations.cpp index 0af2a737358..f6ff454d233 100644 --- a/src/plugins/android/androidconfigurations.cpp +++ b/src/plugins/android/androidconfigurations.cpp @@ -892,7 +892,7 @@ QVersionNumber AndroidConfig::buildToolsVersion() const //TODO: return version according to qt version QVersionNumber maxVersion; QDir buildToolsDir(m_sdkLocation.pathAppended("build-tools").toString()); - for (const QFileInfo &file: buildToolsDir.entryList(QDir::Dirs|QDir::NoDotAndDotDot)) + for (const QFileInfo &file: buildToolsDir.entryInfoList(QDir::Dirs|QDir::NoDotAndDotDot)) maxVersion = qMax(maxVersion, QVersionNumber::fromString(file.fileName())); return maxVersion; } diff --git a/src/plugins/debugger/breakhandler.cpp b/src/plugins/debugger/breakhandler.cpp index eddf5995270..13db44f7ca8 100644 --- a/src/plugins/debugger/breakhandler.cpp +++ b/src/plugins/debugger/breakhandler.cpp @@ -2495,7 +2495,7 @@ GlobalBreakpoint BreakpointManager::findBreakpointFromContext(const ContextData matchLevel = 2; bestMatch = gbp; } else if (matchLevel < 2) { - for (const QPointer engine : EngineManager::engines()) { + for (const QPointer &engine : EngineManager::engines()) { BreakHandler *handler = engine->breakHandler(); for (Breakpoint bp : handler->breakpoints()) { if (bp->globalBreakpoint() == gbp) { diff --git a/src/plugins/debugger/cdb/cdbengine.cpp b/src/plugins/debugger/cdb/cdbengine.cpp index 0122d43eb3a..056991b06bf 100644 --- a/src/plugins/debugger/cdb/cdbengine.cpp +++ b/src/plugins/debugger/cdb/cdbengine.cpp @@ -1034,7 +1034,7 @@ void CdbEngine::runCommand(const DebuggerCommand &dbgCmd) } QTC_CHECK(argumentSplitPos == arguments.size()); int tokenPart = splittedArguments.size(); - for (const QStringRef part : qAsConst(splittedArguments)) + for (const QStringRef &part : qAsConst(splittedArguments)) str << prefix << " -t " << token << '.' << --tokenPart << ' ' << part << '\n'; } else { cmd = prefix; diff --git a/src/plugins/debugger/debuggerruncontrol.cpp b/src/plugins/debugger/debuggerruncontrol.cpp index 80c23fbef15..db8fed7ee60 100644 --- a/src/plugins/debugger/debuggerruncontrol.cpp +++ b/src/plugins/debugger/debuggerruncontrol.cpp @@ -689,7 +689,7 @@ void DebuggerRunTool::start() if (m_runParameters.startMode == StartInternal) { QStringList unhandledIds; - for (const GlobalBreakpoint bp : BreakpointManager::globalBreakpoints()) { + for (const GlobalBreakpoint &bp : BreakpointManager::globalBreakpoints()) { // if (bp->isEnabled() && !m_engine->acceptsBreakpoint(bp)) // unhandledIds.append(bp.id().toString()); } diff --git a/src/plugins/debugger/disassembleragent.cpp b/src/plugins/debugger/disassembleragent.cpp index 97e08b47fe7..baa5e7c84db 100644 --- a/src/plugins/debugger/disassembleragent.cpp +++ b/src/plugins/debugger/disassembleragent.cpp @@ -337,7 +337,7 @@ void DisassemblerAgent::setContentsToDocument(const DisassemblerLines &contents) .arg(d->location.functionName())); const Breakpoints bps = d->engine->breakHandler()->breakpoints(); - for (const Breakpoint bp : bps) + for (const Breakpoint &bp : bps) updateBreakpointMarker(bp); updateLocationMarker(); diff --git a/src/plugins/mcusupport/mcusupportsdk.cpp b/src/plugins/mcusupport/mcusupportsdk.cpp index bd57cd5c50e..33a7063c092 100644 --- a/src/plugins/mcusupport/mcusupportsdk.cpp +++ b/src/plugins/mcusupport/mcusupportsdk.cpp @@ -303,7 +303,7 @@ void hardcodedTargetsAndPackages(const Utils::FilePath &dir, QVectordirectChildren.clear(); - for (const auto priFiles : qAsConst(result->priFiles)) { + for (const auto &priFiles : qAsConst(result->priFiles)) { priFiles.first->finishInitialization(m_buildSystem, this); priFiles.first->update(priFiles.second); } diff --git a/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp b/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp index 048a60a3584..8371031093f 100644 --- a/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp +++ b/src/plugins/qmldesigner/components/formeditor/formeditoritem.cpp @@ -718,7 +718,7 @@ public: if (from == node.rootModelNode()) { isStartLine = true; } else { - for (const ModelNode wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) { + for (const ModelNode &wildcard : QmlFlowViewNode(node.rootModelNode()).wildcards()) { if (wildcard.bindingProperty("target").resolveToModelNode() == node.modelNode()) { from = wildcard; isWildcardLine = true; diff --git a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp index e2f0602cc24..023a09ec03a 100644 --- a/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp +++ b/src/plugins/qmldesigner/designercore/model/qmlitemnode.cpp @@ -628,7 +628,7 @@ ModelNode QmlFlowActionAreaNode::decisionNodeForTransition(const ModelNode &tran } QmlFlowViewNode flowView(view()->rootModelNode()); if (flowView.isValid()) { - for (const ModelNode target : flowView.decicions()) { + for (const ModelNode &target : flowView.decicions()) { if (target.hasBindingProperty("targets") && target.bindingProperty("targets").resolveToModelNodeList().contains(transition)) return target; @@ -782,7 +782,7 @@ ModelNode QmlFlowTargetNode::findSourceForDecisionNode() const if (!isFlowDecision()) return {}; - for (const ModelNode transition : flowView().transitionsForTarget(modelNode())) { + for (const ModelNode &transition : flowView().transitionsForTarget(modelNode())) { if (transition.hasBindingProperty("from")) { const ModelNode source = transition.bindingProperty("from").resolveToModelNode(); if (source.isValid()) { diff --git a/tests/auto/debugger/tst_dumpers.cpp b/tests/auto/debugger/tst_dumpers.cpp index f333f5068a5..20a197f8024 100644 --- a/tests/auto/debugger/tst_dumpers.cpp +++ b/tests/auto/debugger/tst_dumpers.cpp @@ -1496,7 +1496,7 @@ void tst_Dumpers::dumper() } }; collectExpandedINames(data.checks); - for (const auto checkset : qAsConst(data.checksets)) + for (const auto &checkset : qAsConst(data.checksets)) collectExpandedINames(checkset.checks); QString expanded;