From ec28a4b0f3742ae4b425644e36df4c620914364a Mon Sep 17 00:00:00 2001 From: Ulf Hermann Date: Thu, 11 Aug 2016 11:19:57 +0200 Subject: [PATCH] QmlProfiler: Work around QProcess not emitting errorOccurred When given an empty string as executable and some non-empty arguments QProcess might emit error() but not errorOccurred(). This was fixed by 2f0ffba638bdb868a810bc0349c240b6b6e172cd in qtbase, but we cannot rely on that being present, yet. Thus, avoid passing empty strings as executable. Change-Id: Ia1bb5ebceb6edeca1e54489d12b838f3cea8851e Reviewed-by: Orgad Shaneh Reviewed-by: Christian Kandeler --- src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp index d6785f5f9b3..6fee07966a2 100644 --- a/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp +++ b/src/plugins/qmlprofiler/tests/localqmlprofilerrunner_test.cpp @@ -41,6 +41,7 @@ void LocalQmlProfilerRunnerTest::testRunner() { Debugger::AnalyzerConnection connection; LocalQmlProfilerRunner::Configuration configuration; + configuration.debuggee.executable = "\\-/|\\-/"; configuration.debuggee.environment = Utils::Environment::systemEnvironment(); // should not be used anywhere but cannot be empty