ProjectExplorer: Add function for retrieving toolchain factory by type

Change-Id: I0968738c50e7fce56a016c4801054131a1ea33c9
Reviewed-by: hjk <hjk@qt.io>

src/plugins/mcusupport/mcupackage.cpp

@@ -447,13 +447,8 @@ static Toolchain *armGccToolchain(const FilePath &path, Id language)
         return t->compilerCommand() == path && t->language() == language;
     });
     if (!toolChain) {
-        ToolchainFactory *gccFactory
-            = Utils::findOrDefault(ToolchainFactory::allToolchainFactories(),
-                                   [](ToolchainFactory *f) {
-                                       return f->supportedToolchainType()
-                                              == ProjectExplorer::Constants::GCC_TOOLCHAIN_TYPEID;
-                                   });
-        if (gccFactory) {
+        if (ToolchainFactory * const gccFactory = ToolchainFactory::factoryForType(
+                ProjectExplorer::Constants::GCC_TOOLCHAIN_TYPEID)) {
             const QList<Toolchain *> detected = gccFactory->detectForImport({path, language});
             if (!detected.isEmpty()) {
                 toolChain = detected.first();
@@ -474,13 +469,8 @@ static Toolchain *iarToolchain(const FilePath &path, Id language)
                && t->language() == language;
     });
     if (!toolChain) {
-        ToolchainFactory *iarFactory
-            = Utils::findOrDefault(ToolchainFactory::allToolchainFactories(),
-                                   [](ToolchainFactory *f) {
-                                       return f->supportedToolchainType()
-                                              == BareMetal::Constants::IAREW_TOOLCHAIN_TYPEID;
-                                   });
-        if (iarFactory) {
+        if (ToolchainFactory * const iarFactory = ToolchainFactory::factoryForType(
+                BareMetal::Constants::IAREW_TOOLCHAIN_TYPEID)) {
             Toolchains detected = iarFactory->autoDetect(
                 {{}, DeviceManager::defaultDesktopDevice(), {}});
             if (detected.isEmpty())

src/plugins/projectexplorer/toolchain.cpp

@@ -220,8 +220,7 @@ bool Toolchain::operator == (const Toolchain &tc) const
 
 Toolchain *Toolchain::clone() const
 {
-    for (ToolchainFactory *f : std::as_const(toolchainFactories())) {
-        if (f->supportedToolchainType() == d->m_typeId) {
+    if (ToolchainFactory *const f = ToolchainFactory::factoryForType(d->m_typeId)) {
         Toolchain *tc = f->create();
         QTC_ASSERT(tc, return nullptr);
         Store data;
@@ -231,7 +230,6 @@ Toolchain *Toolchain::clone() const
         tc->d->m_id = QUuid::createUuid().toByteArray();
         return tc;
     }
-    }
     QTC_CHECK(false);
     return nullptr;
 }
@@ -573,6 +571,13 @@ const QList<ToolchainFactory *> ToolchainFactory::allToolchainFactories()
     return toolchainFactories();
 }
 
+ToolchainFactory *ToolchainFactory::factoryForType(Id typeId)
+{
+    return Utils::findOrDefault(allToolchainFactories(), [typeId](ToolchainFactory *factory) {
+        return factory->supportedToolchainType() == typeId;
+    });
+}
+
 Toolchains ToolchainFactory::autoDetect(const ToolchainDetector &detector) const
 {
     Q_UNUSED(detector)

src/plugins/projectexplorer/toolchain.h

@@ -265,6 +265,7 @@ public:
     virtual ~ToolchainFactory();
 
     static const QList<ToolchainFactory *> allToolchainFactories();
+    static ToolchainFactory *factoryForType(Utils::Id typeId);
 
     QString displayName() const { return m_displayName; }
     Utils::Id supportedToolchainType() const;

src/plugins/projectexplorer/toolchainsettingsaccessor.cpp

@@ -267,8 +267,7 @@ Toolchains ToolchainSettingsAccessor::toolChains(const Store &data) const
         bool restored = false;
         const Utils::Id tcType = ToolchainFactory::typeIdFromMap(tcMap);
         if (tcType.isValid()) {
-            for (ToolchainFactory *f : factories) {
-                if (f->supportedToolchainType() == tcType) {
+            if (ToolchainFactory * const f = ToolchainFactory::factoryForType(tcType)) {
                 if (Toolchain *tc = f->restore(tcMap)) {
                     result.append(tc);
                     restored = true;
@@ -276,7 +275,6 @@ Toolchains ToolchainSettingsAccessor::toolChains(const Store &data) const
                 }
             }
         }
-        }
         if (!restored)
             qWarning("Warning: Unable to restore compiler type '%s' for tool chain %s.",
                      qPrintable(tcType.toString()),