feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

AppMan: Only allow Debugging/Profiling with a Linux kit

Browse Source 
Change-Id: I196fe6cc85065c3d9965f5fbb342f377bd221d95
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Dominik Holland
2024-02-07 15:46:51 +01:00
parent 3b2a4fd3f2
commit ecc3879cf4
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
src/plugins/qtapplicationmanager/appmanagerrunconfiguration.cpp
View File

@@ -90,9 +90,10 @@ public:
return !tis.isEmpty(); return !tis.isEmpty();
} }
virtual bool filterTarget(const TargetInformation &ti) const virtual bool filterTarget(Target *target, const TargetInformation &ti) const
{ {
return !ti.manifest.supportsDebugging(); return !ti.manifest.supportsDebugging() ||
DeviceKitAspect::device(target->kit())->osType() != OsType::OsTypeLinux;
} }
QList<RunConfigurationCreationInfo> availableCreators(Target *target) const QList<RunConfigurationCreationInfo> availableCreators(Target *target) const
@@ -102,8 +103,8 @@ public:
Qt::UniqueConnection); Qt::UniqueConnection);
const auto buildTargets = TargetInformation::readFromProject(target); const auto buildTargets = TargetInformation::readFromProject(target);
const auto filteredTargets = Utils::filtered(buildTargets, [this](const TargetInformation &ti){ const auto filteredTargets = Utils::filtered(buildTargets, [this, target](const TargetInformation &ti) {
return filterTarget(ti); return filterTarget(target, ti);
}); });
auto result = Utils::transform(filteredTargets, [this, target](const TargetInformation &ti) { auto result = Utils::transform(filteredTargets, [this, target](const TargetInformation &ti) {
@@ -143,9 +144,9 @@ public:
addSupportedTargetDeviceType(Qdb::Constants::QdbLinuxOsType); addSupportedTargetDeviceType(Qdb::Constants::QdbLinuxOsType);
} }
virtual bool filterTarget(const TargetInformation &ti) const final virtual bool filterTarget(Target *target, const TargetInformation &ti) const final
{ {
return ti.manifest.supportsDebugging(); return !AppManagerRunConfigurationFactory::filterTarget(target, ti);
} }
}; };