From eccebe41dc452848871b17fb2e279637da5efe64 Mon Sep 17 00:00:00 2001 From: Jarek Kobus Date: Wed, 18 Nov 2020 17:00:27 +0100 Subject: [PATCH] Fix a warning about calling virtual method from d'tor Fix the following clang-tidy warning: Call to virtual method 'IosRunner::stop' during destruction bypasses virtual dispatch [clang-analyzer-optin.cplusplus.VirtualCall] Remove the reimplementation of IosRunSupport::stop(), as it was calling base implementation. Make base IosRunner::stop() a final method. Change-Id: I8e57a6dd6a44d2a6f00f5af96a11530f62c92429 Reviewed-by: Eike Ziller --- src/plugins/ios/iosrunner.cpp | 5 ----- src/plugins/ios/iosrunner.h | 3 +-- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/src/plugins/ios/iosrunner.cpp b/src/plugins/ios/iosrunner.cpp index ccc349975e6..f7ba1523f93 100644 --- a/src/plugins/ios/iosrunner.cpp +++ b/src/plugins/ios/iosrunner.cpp @@ -369,11 +369,6 @@ void IosRunSupport::start() IosRunner::start(); } -void IosRunSupport::stop() -{ - IosRunner::stop(); -} - // // IosQmlProfilerSupport // diff --git a/src/plugins/ios/iosrunner.h b/src/plugins/ios/iosrunner.h index 8c8fab4a604..6fa5dc2d4bf 100644 --- a/src/plugins/ios/iosrunner.h +++ b/src/plugins/ios/iosrunner.h @@ -60,7 +60,7 @@ public: QmlDebug::QmlDebugServicesPreset qmlDebugServices() const; void start() override; - void stop() override; + void stop() override final; virtual void appOutput(const QString &/*output*/) {} virtual void errorMsg(const QString &/*msg*/) {} @@ -106,7 +106,6 @@ public: void didStartApp(IosToolHandler::OpStatus status); private: void start() override; - void stop() override; };