feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

MiniProjectTargetSelector: Fix wrong sorting

Browse Source 
We need to sort indexes based on results. Also fix that with
too tooSmall being true, <= was used instead of <.

Broken in 12103e0f67

Change-Id: Ia8b7484fdea41776050b1a7ef85789cc49deab78
Reviewed-by: Nikita Baryshnikov <nib952051@gmail.com>
Reviewed-by: Daniel Teske <daniel.teske@digia.com>
This commit is contained in:
Daniel Teske
2014-07-09 12:56:30 +02:00
parent cfc7cae6c5
commit ece0c7c937
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
src/plugins/projectexplorer/miniprojecttargetselector.cpp
View File

@@ -780,9 +780,15 @@ QVector<int> MiniProjectTargetSelector::listWidgetWidths(int minSize, int maxSiz
if (result[i] != -1) if (result[i] != -1)
indexes.append(i); indexes.append(i);
Utils::sort(indexes, [&](int i, int j) -> bool { if (tooSmall) {
return (result[i] > result[j]) ^ tooSmall; Utils::sort(indexes, [&result](int i, int j) {
}); return result[i] < result[j];
});
} else {
Utils::sort(indexes, [&result](int i, int j) {
return result[i] > result[j];
});
}
int i = 0; int i = 0;
int first = result[indexes.first()]; // biggest or smallest int first = result[indexes.first()]; // biggest or smallest