feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Debugger: Avoid now unusual external trigger of readSettings()

Browse Source 
Change-Id: I5a3c9f07e7b07184916b5ca3b95a8966c62193eb
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2023-07-18 14:02:24 +02:00
parent 032ba45fae
commit ece7ae6bb5
4 changed files with 2 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/debugger/commonoptionspage.cpp
View File

@@ -127,6 +127,8 @@ CommonSettings::CommonSettings()
"does not provide reliable information as it does not use scope " "does not provide reliable information as it does not use scope "
"information, it is switched off by default.")); "information, it is switched off by default."));
useToolTipsInMainEditor.setDefaultValue(true); useToolTipsInMainEditor.setDefaultValue(true);
readSettings();
} }
CommonSettings::~CommonSettings() CommonSettings::~CommonSettings()

3
src/plugins/debugger/debuggeractions.cpp
View File

@@ -368,10 +368,7 @@ DebuggerSettings::DebuggerSettings() :
if (auto boolAspect = dynamic_cast<BoolAspect *>(aspect)) if (auto boolAspect = dynamic_cast<BoolAspect *>(aspect))
boolAspect->setLabelPlacement(BoolAspect::LabelPlacement::AtCheckBox); boolAspect->setLabelPlacement(BoolAspect::LabelPlacement::AtCheckBox);
}); });
}
void DebuggerSettings::readSettings()
{
all.readSettings(); all.readSettings();
} }

1
src/plugins/debugger/debuggeractions.h
View File

@@ -124,7 +124,6 @@ public:
Utils::AspectContainer page5; // CDB Utils::AspectContainer page5; // CDB
Utils::AspectContainer page6; // CDB Paths Utils::AspectContainer page6; // CDB Paths
void readSettings();
void writeSettings() const; void writeSettings() const;
private: private:

2
src/plugins/debugger/debuggerplugin.cpp
View File

@@ -771,8 +771,6 @@ DebuggerPluginPrivate::DebuggerPluginPrivate(const QStringList &arguments)
Tr::tr("Debugger Runtime"), Tr::tr("Debugger Runtime"),
Tr::tr("Issues with starting the debugger.")}); Tr::tr("Issues with starting the debugger.")});
settings().readSettings();
const auto addLabel = [](QWidget *widget, const QString &text) { const auto addLabel = [](QWidget *widget, const QString &text) {
auto vbox = qobject_cast<QVBoxLayout *>(widget->layout()); auto vbox = qobject_cast<QVBoxLayout *>(widget->layout());
QTC_ASSERT(vbox, return); QTC_ASSERT(vbox, return);