feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ExtensionSystem/Core: Use more std::chrono

Browse Source 
It is more descriptive than an int.

Change-Id: Ibcb8c3c6210bfa414bb33e36ee401c97ca5fab75
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
Reviewed-by: Qt CI Bot <qt_ci_bot@qt-project.org>
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
Eike Ziller
2024-01-19 14:29:20 +01:00
parent 52fb6f925b
commit ed1b6b958a
6 changed files with 12 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/libs/extensionsystem/pluginmanager.cpp
View File

@@ -55,7 +55,7 @@ Q_LOGGING_CATEGORY(pluginLog, "qtc.extensionsystem", QtWarningMsg)
const char C_IGNORED_PLUGINS[] = "Plugins/Ignored";
const char C_FORCEENABLED_PLUGINS[] = "Plugins/ForceEnabled";
const int DELAYED_INITIALIZE_INTERVAL = 20; // ms
const std::chrono::milliseconds DELAYED_INITIALIZE_INTERVAL{20};
enum { debugLeaks = 0 };

3
src/plugins/coreplugin/icore.cpp
View File

@@ -1344,7 +1344,8 @@ void ICorePrivate::init()
if (HostOsInfo::isLinuxHost()) {
m_trimTimer.setSingleShot(true);
m_trimTimer.setInterval(60000);
using namespace std::chrono_literals;
m_trimTimer.setInterval(60s);
// glibc may not actually free memory in free().
#ifdef Q_OS_LINUX
connect(&m_trimTimer, &QTimer::timeout, this, [] { malloc_trim(0); });

4
src/plugins/coreplugin/locator/locator.cpp
View File

@@ -163,7 +163,7 @@ void Locator::loadSettings()
: QString("QuickOpen");
const Settings def;
DB::beginGroup(settingsGroup);
m_refreshTimer.setInterval(DB::value("RefreshInterval", 60).toInt() * 60000);
m_refreshTimer.setInterval(std::chrono::minutes(DB::value("RefreshInterval", 60).toInt()));
m_settings.useCenteredPopup = DB::value(kUseCenteredPopup, def.useCenteredPopup).toBool();
for (ILocatorFilter *filter : std::as_const(m_filters)) {
@@ -359,7 +359,7 @@ void Locator::setRefreshInterval(int interval)
m_refreshTimer.setInterval(0);
return;
}
m_refreshTimer.setInterval(interval * 60000);
m_refreshTimer.setInterval(std::chrono::minutes(interval));
m_refreshTimer.start();
}

3
src/plugins/coreplugin/locator/locatorwidget.cpp
View File

@@ -612,7 +612,8 @@ LocatorWidget::LocatorWidget(Locator *locator)
m_progressIndicator->raise();
m_progressIndicator->hide();
m_showProgressTimer.setSingleShot(true);
m_showProgressTimer.setInterval(50); // don't show progress for < 50ms tasks
using namespace std::chrono_literals;
m_showProgressTimer.setInterval(50ms); // don't show progress for < 50ms tasks
connect(&m_showProgressTimer, &QTimer::timeout,
this, [this] { setProgressIndicatorVisible(true); });

5
src/plugins/coreplugin/outputwindow.cpp
View File

@@ -37,6 +37,7 @@
const int chunkSize = 10000;
using namespace Utils;
using namespace std::chrono_literals;
namespace Core {
@@ -89,7 +90,7 @@ OutputWindow::OutputWindow(Context context, const Key &settingsKey, QWidget *par
d->formatter.setPlainTextEdit(this);
d->queueTimer.setSingleShot(true);
d->queueTimer.setInterval(10);
d->queueTimer.setInterval(10ms);
connect(&d->queueTimer, &QTimer::timeout, this, &OutputWindow::handleNextOutputChunk);
d->settingsKey = settingsKey;
@@ -149,7 +150,7 @@ OutputWindow::OutputWindow(Context context, const Key &settingsKey, QWidget *par
cutAction->setEnabled(false);
copyAction->setEnabled(false);
d->scrollTimer.setInterval(10);
d->scrollTimer.setInterval(10ms);
d->scrollTimer.setSingleShot(true);
connect(&d->scrollTimer, &QTimer::timeout,
this, &OutputWindow::scrollToBottom);

3
src/plugins/coreplugin/welcomepagehelper.cpp
View File

@@ -644,7 +644,8 @@ void ListItemDelegate::goon()
SectionedGridView::SectionedGridView(QWidget *parent)
: QStackedWidget(parent)
{
m_searchTimer.setInterval(320);
using namespace std::chrono_literals;
m_searchTimer.setInterval(320ms);
m_searchTimer.setSingleShot(true);
connect(&m_searchTimer, &QTimer::timeout, this, [this] {
setSearchString(m_delayedSearchString);