feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Docker: Simplify DockerOptionsPage setup

Browse Source 
Change-Id: Id850de98968c7cb80c813a6fa8cd48543de24fd6
Reviewed-by: Alessandro Portale <alessandro.portale@qt.io>
This commit is contained in:
hjk
2021-03-31 17:28:24 +02:00
parent cbc26f5dce
commit ed2fba8f58
1 changed files with 18 additions and 44 deletions
Download Patch File Download Diff File Expand all files Collapse all files

62
src/plugins/docker/dockersettings.cpp
View File

@@ -105,56 +105,30 @@ void DockerSettings::readSettings(const QSettings *settings)
// DockerOptionsPage // DockerOptionsPage
class DockerConfigWidget : public Core::IOptionsPageWidget
{
Q_DECLARE_TR_FUNCTIONS(Docker::Internal::DockerConfigWidget)
public:
explicit DockerConfigWidget(DockerSettings *settings);
void apply() final
{
m_settings->apply();
m_settings->writeSettings(Core::ICore::settings());
}
void finish() final
{
m_settings->finish();
}
private:
DockerSettings *m_settings;
};
DockerConfigWidget::DockerConfigWidget(DockerSettings *settings)
: m_settings(settings)
{
using namespace Layouting;
DockerSettings &s = *settings;
Column {
Group {
Title(tr("Search images on Docker Hub")),
Form {
s.imageListFilter,
s.imageList
},
},
Stretch()
}.attachTo(this);
}
// DockerOptionsPage
DockerOptionsPage::DockerOptionsPage(DockerSettings *settings) DockerOptionsPage::DockerOptionsPage(DockerSettings *settings)
{ {
setId(Constants::DOCKER_SETTINGS_ID); setId(Constants::DOCKER_SETTINGS_ID);
setDisplayName(DockerConfigWidget::tr("Docker")); setDisplayName(DockerSettings::tr("Docker"));
setCategory(ProjectExplorer::Constants::DEVICE_SETTINGS_CATEGORY); setCategory(ProjectExplorer::Constants::DEVICE_SETTINGS_CATEGORY);
setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Devices")); setDisplayCategory(QCoreApplication::translate("ProjectExplorer", "Devices"));
setCategoryIconPath(":/projectexplorer/images/settingscategory_devices.png"); setCategoryIconPath(":/projectexplorer/images/settingscategory_devices.png");
setWidgetCreator([settings] { return new DockerConfigWidget(settings); }); setSettings(settings);
setLayouter([settings](QWidget *widget) {
using namespace Layouting;
DockerSettings &s = *settings;
Column {
Group {
Title(DockerSettings::tr("Search images on Docker Hub")),
Form {
s.imageListFilter,
s.imageList
},
},
Stretch()
}.attachTo(widget);
});
} }
} // Internal } // Internal