feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QtSupport: Do not set visibility for items without parent

Browse Source 
Avoids having the item popping up separately before adding it to
its respective parent.

Change-Id: I7e7d4765ebf8b1937f50670cbf04ab3bf6edbecd
Reviewed-by: hjk <hjk@qt.io>
This commit is contained in:
Christian Stenger
2021-03-19 15:30:54 +01:00
parent efa9d258a2
commit eda5fbd645
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/qtsupport/qtbuildaspects.cpp
View File

@@ -67,7 +67,7 @@ void QmlDebuggingAspect::addToLayout(LayoutBuilder &builder)
warningLabel->setText(warningText); warningLabel->setText(warningText);
setVisible(supported); setVisible(supported);
const bool warningLabelsVisible = supported && !warningText.isEmpty(); const bool warningLabelsVisible = supported && !warningText.isEmpty();
if (!warningLabel->parentWidget()) if (warningLabel->parentWidget())
warningLabel->setVisible(warningLabelsVisible); warningLabel->setVisible(warningLabelsVisible);
}; };
connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler); connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler);
@@ -87,6 +87,7 @@ void QtQuickCompilerAspect::addToLayout(LayoutBuilder &builder)
SelectionAspect::addToLayout(builder); SelectionAspect::addToLayout(builder);
const auto warningLabel = new Utils::InfoLabel({}, Utils::InfoLabel::Warning); const auto warningLabel = new Utils::InfoLabel({}, Utils::InfoLabel::Warning);
warningLabel->setElideMode(Qt::ElideNone); warningLabel->setElideMode(Qt::ElideNone);
warningLabel->setVisible(false);
builder.addRow({{}, warningLabel}); builder.addRow({{}, warningLabel});
const auto changeHandler = [this, warningLabel] { const auto changeHandler = [this, warningLabel] {
QString warningText; QString warningText;
@@ -101,7 +102,8 @@ void QtQuickCompilerAspect::addToLayout(LayoutBuilder &builder)
warningLabel->setText(warningText); warningLabel->setText(warningText);
setVisible(supported); setVisible(supported);
const bool warningLabelsVisible = supported && !warningText.isEmpty(); const bool warningLabelsVisible = supported && !warningText.isEmpty();
warningLabel->setVisible(warningLabelsVisible); if (warningLabel->parentWidget())
warningLabel->setVisible(warningLabelsVisible);
}; };
connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler); connect(KitManager::instance(), &KitManager::kitsChanged, this, changeHandler);
connect(this, &QmlDebuggingAspect::changed, this, changeHandler); connect(this, &QmlDebuggingAspect::changed, this, changeHandler);