feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Terminal: Remove TOO_OLD_WINSDK check from libptyqt

Browse Source 
Qt Creator will always use newer Windows SDKs, as we require at least
Windows 10 1809.

The define for TOO_OLD_WINSDK was done arbitrarily and broke
(LLVM-)MinGW builds.

Change-Id: If8e1fd4e0e3615bda23483877e67988ca04ea9f7
Reviewed-by: Marcus Tillmanns <marcus.tillmanns@qt.io>
This commit is contained in:
Cristian Adam
2024-06-28 14:49:16 +02:00
parent 9d8dc1d056
commit ee54b2cfca
2 changed files with 0 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/libs/3rdparty/libptyqt/conptyprocess.cpp vendored
View File

@@ -1132,10 +1132,6 @@ qint64 ConPtyProcess::write(const QByteArray &byteArray)
bool ConPtyProcess::isAvailable() bool ConPtyProcess::isAvailable()
{ {
#ifdef TOO_OLD_WINSDK
return false; //very importnant! ConPty can be built, but it doesn't work if built with old sdk and Win10 < 1903
#endif
qint32 buildNumber = QSysInfo::kernelVersion().split(".").last().toInt(); qint32 buildNumber = QSysInfo::kernelVersion().split(".").last().toInt();
if (buildNumber < CONPTY_MINIMAL_WINDOWS_VERSION) if (buildNumber < CONPTY_MINIMAL_WINDOWS_VERSION)
return false; return false;

1
src/libs/3rdparty/libptyqt/conptyprocess.h vendored
View File

@@ -20,7 +20,6 @@
typedef VOID* HPCON; typedef VOID* HPCON;
#define TOO_OLD_WINSDK
#endif #endif
class QWinEventNotifier; class QWinEventNotifier;