From ee8ad68f5b31b9b27816f7fe6337fbeec6a1563a Mon Sep 17 00:00:00 2001 From: Sami Shalayel Date: Mon, 27 May 2024 09:26:29 +0200 Subject: [PATCH] Enable qmlls by default Change the default values for enabling qmlls to true. Don't use the latest qmlls version by default for now because qmlls will crash on qt 5.15 projects. Also remove the "experimental" from the checkbox text. Fixes: QTCREATORBUG-30851 Change-Id: I6cac396817eecb0d3bd071668d0588ec6eef1d4f Reviewed-by: Ulf Hermann Reviewed-by: David Schulz Reviewed-by: Fabian Kosmale --- src/plugins/qmljseditor/qmljseditingsettingspage.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/qmljseditor/qmljseditingsettingspage.cpp b/src/plugins/qmljseditor/qmljseditingsettingspage.cpp index facf33be474..644c0d1d50e 100644 --- a/src/plugins/qmljseditor/qmljseditingsettingspage.cpp +++ b/src/plugins/qmljseditor/qmljseditingsettingspage.cpp @@ -105,7 +105,7 @@ void QmlJsEditingSettings::fromSettings(QtcSettings *settings) = settings->value(AUTO_FORMAT_ONLY_CURRENT_PROJECT, QVariant(false)).toBool(); m_foldAuxData = settings->value(FOLD_AUX_DATA, QVariant(true)).toBool(); m_uiQmlOpenMode = settings->value(UIQML_OPEN_MODE, "").toString(); - m_qmllsSettings.useQmlls = settings->value(USE_QMLLS, QVariant(false)).toBool(); + m_qmllsSettings.useQmlls = settings->value(USE_QMLLS, QVariant(true)).toBool(); m_qmllsSettings.useLatestQmlls = settings->value(USE_LATEST_QMLLS, QVariant(false)).toBool(); m_qmllsSettings.disableBuiltinCodemodel = settings->value(DISABLE_BUILTIN_CODEMODEL, QVariant(false)).toBool(); @@ -397,7 +397,7 @@ public: uiQmlOpenComboBox->setSizePolicy(QSizePolicy::Maximum, QSizePolicy::Preferred); uiQmlOpenComboBox->setSizeAdjustPolicy(QComboBox::QComboBox::AdjustToContents); - useQmlls = new QCheckBox(Tr::tr("Enable QML Language Server (EXPERIMENTAL!)")); + useQmlls = new QCheckBox(Tr::tr("Enable QML Language Server")); useQmlls->setChecked(s.qmllsSettings().useQmlls); disableBuiltInCodemodel = new QCheckBox( Tr::tr("Use QML Language Server advanced features (renaming, find usages and co.) "