feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind plugin: fix for just partial usage of coreplugin/coreconstants.h values

Browse Source 
Valgrind plugin CallgrindTool and MemcheckTool modules sometime use
coreplugin/coreconstants.h values for icons (e.g. Core::Constants::ICON_REDO),
and sometime - an own constant is used like ":core/images/prev.png".

This commit is fixing this issue and changing everything to Core::Constants
usage.

Change-Id: I8d6f473a66a3181b03e2193314d17661df1d4cc1
Reviewed-by: hjk <qthjk@ovi.com>
This commit is contained in:
Denis Mingulov
2012-01-17 13:06:12 +02:00
committed by hjk
parent f77dfaddd1
commit eed531ff9e
2 changed files with 4 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/valgrind/callgrindtool.cpp
View File

@@ -743,7 +743,7 @@ QWidget *CallgrindToolPrivate::createWidgets()
// go back
action = new QAction(this);
action->setDisabled(true);
action->setIcon(QIcon(QLatin1String(":core/images/prev.png")));
action->setIcon(QIcon(QLatin1String(Core::Constants::ICON_PREV)));
action->setToolTip(tr("Go back one step in history. This will select the previously selected item."));
connect(action, SIGNAL(triggered(bool)), m_stackBrowser, SLOT(goBack()));
layout->addWidget(createToolButton(action));
@@ -752,7 +752,7 @@ QWidget *CallgrindToolPrivate::createWidgets()
// go forward
action = new QAction(this);
action->setDisabled(true);
action->setIcon(QIcon(QLatin1String(":core/images/next.png")));
action->setIcon(QIcon(QLatin1String(Core::Constants::ICON_NEXT)));
action->setToolTip(tr("Go forward one step in history."));
connect(action, SIGNAL(triggered(bool)), m_stackBrowser, SLOT(goNext()));
layout->addWidget(createToolButton(action));