feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CMake: Listen to BuildSystem::parsingFinished, not Target::parsingFinished

Browse Source 
There's a 1:1 relationship between CMakeBuildConfigurations and
CMakeBuildSystem objects. No need to react in one
CMakeBuildConfiguration to the signals of someone elses buddy.

Change-Id: I53f7d02d8852a85b9530bd55d8e059916a22579c
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
This commit is contained in:
hjk
2021-06-10 14:21:47 +02:00
parent d542c81f81
commit eed82176b2
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/cmakeprojectmanager/cmakebuildconfiguration.cpp
View File

@@ -372,7 +372,7 @@ CMakeBuildSettingsWidget::CMakeBuildSettingsWidget(CMakeBuildConfiguration *bc)
m_configView->expandAll(); m_configView->expandAll();
} }
connect(bc->target(), &Target::parsingFinished, this, [this, stretcher] { connect(bc->buildSystem(), &BuildSystem::parsingFinished, this, [this, stretcher] {
m_configModel->setConfiguration(m_buildConfiguration->configurationFromCMake()); m_configModel->setConfiguration(m_buildConfiguration->configurationFromCMake());
m_configView->expandAll(); m_configView->expandAll();
m_configView->setEnabled(true); m_configView->setEnabled(true);