feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Core: Rename ExternalTool::fileName() to filePath()

Browse Source 
Also, setFilePath(), and some code cosmetics.

Change-Id: If24aa2d75276eafac4d7494153c5fc223be1ee8b
Reviewed-by: Eike Ziller <eike.ziller@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
hjk
2022-11-24 17:29:55 +01:00
parent 67e9c2d7a0
commit ef97774122
3 changed files with 23 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/coreplugin/externaltool.cpp
View File

@@ -187,9 +187,9 @@ bool ExternalTool::modifiesCurrentDocument() const
return m_modifiesCurrentDocument;
}
void ExternalTool::setFileName(const Utils::FilePath &fileName)
void ExternalTool::setFilePath(const FilePath &filePath)
{
m_filePath = fileName;
m_filePath = filePath;
}
void ExternalTool::setPreset(QSharedPointer<ExternalTool> preset)
@@ -197,7 +197,7 @@ void ExternalTool::setPreset(QSharedPointer<ExternalTool> preset)
m_presetTool = preset;
}
Utils::FilePath ExternalTool::fileName() const
FilePath ExternalTool::filePath() const
{
return m_filePath;
}
@@ -440,9 +440,10 @@ ExternalTool * ExternalTool::createFromXml(const QByteArray &xml, QString *error
return tool;
}
ExternalTool * ExternalTool::createFromFile(const Utils::FilePath &fileName, QString *errorMessage, const QString &locale)
ExternalTool * ExternalTool::createFromFile(const FilePath &fileName, QString *errorMessage,
const QString &locale)
{
Utils::FilePath absFileName = fileName.absoluteFilePath();
FilePath absFileName = fileName.absoluteFilePath();
FileReader reader;
if (!reader.fetch(absFileName, errorMessage))
return nullptr;