From efa0f7464599162343037fa0015473939b7a851f Mon Sep 17 00:00:00 2001
From: Eike Ziller <eike.ziller@qt.io>
Date: Thu, 17 Dec 2020 09:21:55 +0100
Subject: [PATCH] TextEditor: Do not pop up general messages pane

General messages pane should only be opened on direct user interaction.

Task-number: QTCREATORBUG-24430
Change-Id: I62f6849ca5a32f0a75c5a91a667ee704d3632d1a
Reviewed-by: David Schulz <david.schulz@qt.io>
---
 src/plugins/texteditor/formattexteditor.cpp |  2 +-
 src/plugins/texteditor/highlighter.cpp      | 21 +++++++++------------
 2 files changed, 10 insertions(+), 13 deletions(-)

diff --git a/src/plugins/texteditor/formattexteditor.cpp b/src/plugins/texteditor/formattexteditor.cpp
index 7b4bb4265c5..248436a9990 100644
--- a/src/plugins/texteditor/formattexteditor.cpp
+++ b/src/plugins/texteditor/formattexteditor.cpp
@@ -281,7 +281,7 @@ static void updateEditorText(QPlainTextEdit *editor, const QString &text)
 
 static void showError(const QString &error)
 {
-    Core::MessageManager::write(
+    Core::MessageManager::writeFlashing(
                 QString(QT_TRANSLATE_NOOP("TextEditor", "Error in text formatting: %1"))
                 .arg(error.trimmed()));
 }
diff --git a/src/plugins/texteditor/highlighter.cpp b/src/plugins/texteditor/highlighter.cpp
index 39c69d5feaf..51e1a307f11 100644
--- a/src/plugins/texteditor/highlighter.cpp
+++ b/src/plugins/texteditor/highlighter.cpp
@@ -236,22 +236,19 @@ void Highlighter::addCustomHighlighterPath(const Utils::FilePath &path)
 void Highlighter::downloadDefinitions(std::function<void()> callback) {
     auto downloader =
         new KSyntaxHighlighting::DefinitionDownloader(highlightRepository());
-    connect(downloader, &KSyntaxHighlighting::DefinitionDownloader::done,
-            [downloader, callback]() {
-                Core::MessageManager::write(tr("Highlighter updates: done"),
-                                            Core::MessageManager::ModeSwitch);
-                downloader->deleteLater();
-                reload();
-                if (callback)
-                    callback();
-            });
+    connect(downloader, &KSyntaxHighlighting::DefinitionDownloader::done, [downloader, callback]() {
+        Core::MessageManager::writeFlashing(tr("Highlighter updates: done"));
+        downloader->deleteLater();
+        reload();
+        if (callback)
+            callback();
+    });
     connect(downloader,
             &KSyntaxHighlighting::DefinitionDownloader::informationMessage,
             [](const QString &message) {
-                Core::MessageManager::write(tr("Highlighter updates:") + ' ' +
-                                                message,
-                                            Core::MessageManager::ModeSwitch);
+                Core::MessageManager::writeSilently(tr("Highlighter updates:") + ' ' + message);
             });
+    Core::MessageManager::writeDisrupting(tr("Highlighter updates: starting"));
     downloader->start();
 }