feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

CppTools: Define '<' and '>' as electrical characters

Browse Source 
Required for auto-indenting stream operations. For example:

std::cout << foo
          << bar;

without explicitly invoking the indenter.

Change-Id: I3a88083af5295709dfecb384538078e236119b0b
Reviewed-by: Nikolai Kosjar <nikolai.kosjar@digia.com>
Reviewed-by: Erik Verbruggen <erik.verbruggen@digia.com>
This commit is contained in:
Orgad Shaneh
2014-04-30 22:55:59 +03:00
committed by Orgad Shaneh
parent 152f9c3646
commit efe316f811
1 changed files with 26 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

43
src/plugins/cpptools/cppqtstyleindenter.cpp
View File

@@ -58,30 +58,39 @@ bool CppQtStyleIndenter::isElectricCharacter(const QChar &ch) const
case '}':
case ':':
case '#':
case '<':
case '>':
return true;
}
return false;
}
static bool colonIsElectric(const QString &text)
static bool isElectricInLine(const QChar ch, const QString &text)
{
// switch cases and access declarations should be reindented
if (text.contains(QLatin1String("case"))
|| text.contains(QLatin1String("default"))
|| text.contains(QLatin1String("public"))
|| text.contains(QLatin1String("private"))
|| text.contains(QLatin1String("protected"))
|| text.contains(QLatin1String("signals"))
|| text.contains(QLatin1String("Q_SIGNALS"))) {
return true;
switch (ch.toLatin1()) {
case ':':
// switch cases and access declarations should be reindented
if (text.contains(QLatin1String("case"))
|| text.contains(QLatin1String("default"))
|| text.contains(QLatin1String("public"))
|| text.contains(QLatin1String("private"))
|| text.contains(QLatin1String("protected"))
|| text.contains(QLatin1String("signals"))
|| text.contains(QLatin1String("Q_SIGNALS"))) {
return true;
}
// fall-through
// lines that start with : might have a constructor initializer list
case '<':
case '>': {
// Electrical if at line beginning (after space indentation)
const QString trimmedtext = text.trimmed();
return !trimmedtext.isEmpty() && trimmedtext.at(0) == ch;
}
}
// lines that start with : might have a constructor initializer list
const QString trimmedtext = text.trimmed();
if (!trimmedtext.isEmpty() && trimmedtext.at(0) == QLatin1Char(':'))
return true;
return false;
return true;
}
void CppQtStyleIndenter::indentBlock(QTextDocument *doc,
@@ -100,7 +109,7 @@ void CppQtStyleIndenter::indentBlock(QTextDocument *doc,
if (isElectricCharacter(typedChar)) {
// : should not be electric for labels
if (typedChar == QLatin1Char(':') && !colonIsElectric(block.text()))
if (!isElectricInLine(typedChar, block.text()))
return;
// only reindent the current line when typing electric characters if the