feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStep::init() signature

Browse Source 
The extra parameter was always computed but used only in one place,
and that use got removed lately.

Change-Id: Ie10c0107ca70ee97ce03f83294992aab8d1a3ffe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-10 15:31:44 +01:00
parent ca24877c93
commit f007bc7593
54 changed files with 69 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/android/androidbuildapkstep.cpp
View File

@@ -133,7 +133,7 @@ AndroidBuildApkStep::AndroidBuildApkStep(BuildStepList *parent)
setImmutable(true);
}
bool AndroidBuildApkStep::init(QList<const BuildStep *> &earlierSteps)
bool AndroidBuildApkStep::init()
{
ProjectExplorer::BuildConfiguration *bc = buildConfiguration();
@@ -193,7 +193,7 @@ bool AndroidBuildApkStep::init(QList<const BuildStep *> &earlierSteps)
m_apkPath = AndroidManager::apkPath(target()).toString();
qCDebug(buildapkstepLog) << "APK path:" << m_apkPath;
if (!AbstractProcessStep::init(earlierSteps))
if (!AbstractProcessStep::init())
return false;
QString command = version->qmakeProperty("QT_HOST_BINS");