feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStep::init() signature

Browse Source 
The extra parameter was always computed but used only in one place,
and that use got removed lately.

Change-Id: Ie10c0107ca70ee97ce03f83294992aab8d1a3ffe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-10 15:31:44 +01:00
parent ca24877c93
commit f007bc7593
54 changed files with 69 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/cmakeprojectmanager/cmakebuildstep.cpp
View File

@@ -146,7 +146,7 @@ bool CMakeBuildStep::fromMap(const QVariantMap &map)
}
bool CMakeBuildStep::init(QList<const BuildStep *> &earlierSteps)
bool CMakeBuildStep::init()
{
bool canInit = true;
CMakeBuildConfiguration *bc = cmakeBuildConfiguration();
@@ -228,7 +228,7 @@ bool CMakeBuildStep::init(QList<const BuildStep *> &earlierSteps)
appendOutputParser(parser);
outputParser()->setWorkingDirectory(pp->effectiveWorkingDirectory());
return AbstractProcessStep::init(earlierSteps);
return AbstractProcessStep::init();
}
void CMakeBuildStep::run(QFutureInterface<bool> &fi)