feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStep::init() signature

Browse Source 
The extra parameter was always computed but used only in one place,
and that use got removed lately.

Change-Id: Ie10c0107ca70ee97ce03f83294992aab8d1a3ffe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-10 15:31:44 +01:00
parent ca24877c93
commit f007bc7593
54 changed files with 69 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
src/plugins/ios/iosbuildstep.cpp
View File

@@ -70,7 +70,7 @@ IosBuildStep::IosBuildStep(BuildStepList *parent) :
}
}
bool IosBuildStep::init(QList<const BuildStep *> &earlierSteps)
bool IosBuildStep::init()
{
BuildConfiguration *bc = buildConfiguration();
if (!bc)
@@ -106,7 +106,7 @@ bool IosBuildStep::init(QList<const BuildStep *> &earlierSteps)
appendOutputParser(parser);
outputParser()->setWorkingDirectory(pp->effectiveWorkingDirectory());
return AbstractProcessStep::init(earlierSteps);
return AbstractProcessStep::init();
}
QVariantMap IosBuildStep::toMap() const

2
src/plugins/ios/iosbuildstep.h
View File

@@ -48,7 +48,7 @@ class IosBuildStep : public ProjectExplorer::AbstractProcessStep
public:
explicit IosBuildStep(ProjectExplorer::BuildStepList *parent);
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;

3
src/plugins/ios/iosdeploystep.cpp
View File

@@ -77,9 +77,8 @@ void IosDeployStep::updateDisplayNames()
setDisplayName(tr("Deploy to %1").arg(devName));
}
bool IosDeployStep::init(QList<const BuildStep *> &earlierSteps)
bool IosDeployStep::init()
{
Q_UNUSED(earlierSteps);
QTC_ASSERT(m_transferStatus == NoTransfer, return false);
m_device = DeviceKitInformation::device(target()->kit());
auto runConfig = qobject_cast<const IosRunConfiguration *>(

2
src/plugins/ios/iosdeploystep.h
View File

@@ -70,7 +70,7 @@ private:
void handleErrorMsg(Ios::IosToolHandler *handler, const QString &msg);
void updateDisplayNames();
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;
ProjectExplorer::IDevice::ConstPtr device() const;
IosDevice::ConstPtr iosdevice() const;

4
src/plugins/ios/iosdsymbuildstep.cpp
View File

@@ -62,7 +62,7 @@ IosDsymBuildStep::IosDsymBuildStep(BuildStepList *parent) :
{
}
bool IosDsymBuildStep::init(QList<const BuildStep *> &earlierSteps)
bool IosDsymBuildStep::init()
{
BuildConfiguration *bc = buildConfiguration();
@@ -85,7 +85,7 @@ bool IosDsymBuildStep::init(QList<const BuildStep *> &earlierSteps)
if (outputParser())
outputParser()->setWorkingDirectory(pp->effectiveWorkingDirectory());
return AbstractProcessStep::init(earlierSteps);
return AbstractProcessStep::init();
}
QVariantMap IosDsymBuildStep::toMap() const

2
src/plugins/ios/iosdsymbuildstep.h
View File

@@ -42,7 +42,7 @@ class IosDsymBuildStep : public ProjectExplorer::AbstractProcessStep
public:
IosDsymBuildStep(ProjectExplorer::BuildStepList *parent);
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;