feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStep::init() signature

Browse Source 
The extra parameter was always computed but used only in one place,
and that use got removed lately.

Change-Id: Ie10c0107ca70ee97ce03f83294992aab8d1a3ffe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-10 15:31:44 +01:00
parent ca24877c93
commit f007bc7593
54 changed files with 69 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/qbsprojectmanager/qbsbuildstep.cpp
View File

@@ -142,9 +142,8 @@ QbsBuildStep::~QbsBuildStep()
delete m_parser;
}
bool QbsBuildStep::init(QList<const BuildStep *> &earlierSteps)
bool QbsBuildStep::init()
{
Q_UNUSED(earlierSteps);
if (project()->isParsing() || m_job)
return false;

3
src/plugins/qbsprojectmanager/qbsbuildstep.h
View File

@@ -58,8 +58,7 @@ public:
explicit QbsBuildStep(ProjectExplorer::BuildStepList *bsl);
~QbsBuildStep() override;
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;

3
src/plugins/qbsprojectmanager/qbscleanstep.cpp
View File

@@ -64,9 +64,8 @@ QbsCleanStep::~QbsCleanStep()
}
}
bool QbsCleanStep::init(QList<const BuildStep *> &earlierSteps)
bool QbsCleanStep::init()
{
Q_UNUSED(earlierSteps);
if (project()->isParsing() || m_job)
return false;

3
src/plugins/qbsprojectmanager/qbscleanstep.h
View File

@@ -45,8 +45,7 @@ public:
explicit QbsCleanStep(ProjectExplorer::BuildStepList *bsl);
~QbsCleanStep() override;
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;

3
src/plugins/qbsprojectmanager/qbsinstallstep.cpp
View File

@@ -80,9 +80,8 @@ QbsInstallStep::~QbsInstallStep()
m_job = nullptr;
}
bool QbsInstallStep::init(QList<const BuildStep *> &earlierSteps)
bool QbsInstallStep::init()
{
Q_UNUSED(earlierSteps);
QTC_ASSERT(!project()->isParsing() && !m_job, return false);
return true;
}

3
src/plugins/qbsprojectmanager/qbsinstallstep.h
View File

@@ -45,8 +45,7 @@ public:
explicit QbsInstallStep(ProjectExplorer::BuildStepList *bsl);
~QbsInstallStep() override;
bool init(QList<const BuildStep *> &earlierSteps) override;
bool init() override;
void run(QFutureInterface<bool> &fi) override;
ProjectExplorer::BuildStepConfigWidget *createConfigWidget() override;