feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify BuildStep::init() signature

Browse Source 
The extra parameter was always computed but used only in one place,
and that use got removed lately.

Change-Id: Ie10c0107ca70ee97ce03f83294992aab8d1a3ffe
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2019-01-10 15:31:44 +01:00
parent ca24877c93
commit f007bc7593
54 changed files with 69 additions and 87 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
src/plugins/qmakeprojectmanager/qmakestep.cpp
View File

@@ -164,8 +164,7 @@ QMakeStepConfig QMakeStep::deducedArguments() const
return config;
}
bool QMakeStep::init(QList<const BuildStep *> &earlierSteps)
bool QMakeStep::init()
{
if (m_commandFuture)
return false;
@@ -254,7 +253,7 @@ bool QMakeStep::init(QList<const BuildStep *> &earlierSteps)
m_scriptTemplate = node->projectType() == ProjectType::ScriptTemplate;
return AbstractProcessStep::init(earlierSteps);
return AbstractProcessStep::init();
}
void QMakeStep::run(QFutureInterface<bool> &fi)