feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: Crash fix

Browse Source 
Throwing for an invalid model node does not make much sense.
I expected it returning false and that it what it does now.

Change-Id: I5c8c1a771e95a39bdb9ab7c30b4e94957464ffc1
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Thomas Hartmann
2017-02-07 15:44:57 +01:00
committed by Tim Jenssen
parent 71007df8fd
commit f04f09e17c
1 changed files with 3 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/plugins/qmldesigner/designercore/model/modelnode.cpp
View File

@@ -870,10 +870,9 @@ bool ModelNode::isSelected() const
*/ */
bool ModelNode::isRootNode() const bool ModelNode::isRootNode() const
{ {
if (!isValid()) { if (!isValid())
Q_ASSERT_X(isValid(), Q_FUNC_INFO, "model node is invalid"); return false;
throw InvalidModelNodeException(__LINE__, __FUNCTION__, __FILE__);
}
return view()->rootModelNode() == *this; return view()->rootModelNode() == *this;
} }