feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlProfiler: Coding style fixes

Browse Source 
Change-Id: I302ea39510043b53464af47c45210c19dd232690
Reviewed-by: Christiaan Janssen <christiaan.janssen@nokia.com>
This commit is contained in:
Kai Koehne
2012-01-13 12:25:53 +01:00
parent 7ef450af6d
commit f0a82fe63e
3 changed files with 226 additions and 211 deletions
Download Patch File Download Diff File Expand all files Collapse all files

45
src/libs/qmljsdebugclient/qmlprofilereventlist.cpp
View File

@@ -1588,39 +1588,48 @@ void QmlProfilerEventList::load()
} }
/////////////////////////////////////////////// ///////////////////////////////////////////////
qint64 QmlProfilerEventList::getStartTime(int index) const { qint64 QmlProfilerEventList::getStartTime(int index) const
{
return d->m_startTimeSortedList[index].startTime; return d->m_startTimeSortedList[index].startTime;
} }
qint64 QmlProfilerEventList::getEndTime(int index) const { qint64 QmlProfilerEventList::getEndTime(int index) const
{
return d->m_startTimeSortedList[index].startTime + d->m_startTimeSortedList[index].length; return d->m_startTimeSortedList[index].startTime + d->m_startTimeSortedList[index].length;
} }
qint64 QmlProfilerEventList::getDuration(int index) const { qint64 QmlProfilerEventList::getDuration(int index) const
{
return d->m_startTimeSortedList[index].length; return d->m_startTimeSortedList[index].length;
} }
int QmlProfilerEventList::getType(int index) const { int QmlProfilerEventList::getType(int index) const
{
return d->m_startTimeSortedList[index].description->eventType; return d->m_startTimeSortedList[index].description->eventType;
} }
int QmlProfilerEventList::getNestingLevel(int index) const { int QmlProfilerEventList::getNestingLevel(int index) const
{
return d->m_startTimeSortedList[index].nestingLevel; return d->m_startTimeSortedList[index].nestingLevel;
} }
int QmlProfilerEventList::getNestingDepth(int index) const { int QmlProfilerEventList::getNestingDepth(int index) const
{
return d->m_startTimeSortedList[index].nestingDepth; return d->m_startTimeSortedList[index].nestingDepth;
} }
QString QmlProfilerEventList::getFilename(int index) const { QString QmlProfilerEventList::getFilename(int index) const
{
return d->m_startTimeSortedList[index].description->filename; return d->m_startTimeSortedList[index].description->filename;
} }
int QmlProfilerEventList::getLine(int index) const { int QmlProfilerEventList::getLine(int index) const
{
return d->m_startTimeSortedList[index].description->line; return d->m_startTimeSortedList[index].description->line;
} }
QString QmlProfilerEventList::getDetails(int index) const { QString QmlProfilerEventList::getDetails(int index) const
{
// special: animations // special: animations
if (d->m_startTimeSortedList[index].description->eventType == QmlJsDebugClient::Painting && if (d->m_startTimeSortedList[index].description->eventType == QmlJsDebugClient::Painting &&
d->m_startTimeSortedList[index].animationCount >= 0) d->m_startTimeSortedList[index].animationCount >= 0)
@@ -1654,37 +1663,43 @@ int QmlProfilerEventList::getMinimumAnimationCount() const
return d->m_minimumAnimationCount; return d->m_minimumAnimationCount;
} }
int QmlProfilerEventList::uniqueEventsOfType(int type) const { int QmlProfilerEventList::uniqueEventsOfType(int type) const
{
if (!d->m_typeCounts.contains(type)) if (!d->m_typeCounts.contains(type))
return 0; return 0;
return d->m_typeCounts[type]->eventIds.count(); return d->m_typeCounts[type]->eventIds.count();
} }
int QmlProfilerEventList::maxNestingForType(int type) const { int QmlProfilerEventList::maxNestingForType(int type) const
{
if (!d->m_typeCounts.contains(type)) if (!d->m_typeCounts.contains(type))
return 0; return 0;
return d->m_typeCounts[type]->nestingCount; return d->m_typeCounts[type]->nestingCount;
} }
QString QmlProfilerEventList::eventTextForType(int type, int index) const { QString QmlProfilerEventList::eventTextForType(int type, int index) const
{
if (!d->m_typeCounts.contains(type)) if (!d->m_typeCounts.contains(type))
return QString(); return QString();
return d->m_eventDescriptions.values().at(d->m_typeCounts[type]->eventIds[index])->details; return d->m_eventDescriptions.values().at(d->m_typeCounts[type]->eventIds[index])->details;
} }
QString QmlProfilerEventList::eventDisplayNameForType(int type, int index) const { QString QmlProfilerEventList::eventDisplayNameForType(int type, int index) const
{
if (!d->m_typeCounts.contains(type)) if (!d->m_typeCounts.contains(type))
return QString(); return QString();
return d->m_eventDescriptions.values().at(d->m_typeCounts[type]->eventIds[index])->displayname; return d->m_eventDescriptions.values().at(d->m_typeCounts[type]->eventIds[index])->displayname;
} }
int QmlProfilerEventList::eventIdForType(int type, int index) const { int QmlProfilerEventList::eventIdForType(int type, int index) const
{
if (!d->m_typeCounts.contains(type)) if (!d->m_typeCounts.contains(type))
return -1; return -1;
return d->m_typeCounts[type]->eventIds[index]; return d->m_typeCounts[type]->eventIds[index];
} }
int QmlProfilerEventList::eventPosInType(int index) const { int QmlProfilerEventList::eventPosInType(int index) const
{
int eventType = d->m_startTimeSortedList[index].description->eventType; int eventType = d->m_startTimeSortedList[index].description->eventType;
return d->m_typeCounts[eventType]->eventIds.indexOf(d->m_startTimeSortedList[index].description->eventId); return d->m_typeCounts[eventType]->eventIds.indexOf(d->m_startTimeSortedList[index].description->eventId);
} }

2
src/plugins/qmlprofiler/tracewindow.cpp
View File

@@ -564,7 +564,7 @@ void TraceWindow::updateProfilerState()
emit profilerStateChanged(qmlActive, v8Active); emit profilerStateChanged(qmlActive, v8Active);
} }
void TraceWindow::updateToolTip(QString text) void TraceWindow::updateToolTip(const QString &text)
{ {
setToolTip(text); setToolTip(text);
} }

2
src/plugins/qmlprofiler/tracewindow.h
View File

@@ -126,7 +126,7 @@ public slots:
void v8Complete(); void v8Complete();
void selectNextEvent(int eventId); void selectNextEvent(int eventId);
void updateProfilerState(); void updateProfilerState();
void updateToolTip(QString text); void updateToolTip(const QString &text);
signals: signals:
void viewUpdated(); void viewUpdated();