From f10a524f057b51fd9d8ec03f50e3d76bacf50047 Mon Sep 17 00:00:00 2001
From: hjk <hjk@qt.io>
Date: Tue, 4 Apr 2023 16:10:21 +0200
Subject: [PATCH] Remove some QList::toVector() no-ops

Change-Id: I4d7ecf26a2d18b7e58e8bbae8d1b12f3e73924d9
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
---
 src/plugins/android/androidconfigurations.cpp                 | 2 +-
 src/plugins/clangtools/clangtoolsutils.cpp                    | 4 ++--
 src/plugins/languageclient/locatorfilter.cpp                  | 2 +-
 .../qmldesigner/designercore/instances/nodeinstanceview.cpp   | 4 ++--
 4 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/plugins/android/androidconfigurations.cpp b/src/plugins/android/androidconfigurations.cpp
index 4616cff2aed..cf1b005bde5 100644
--- a/src/plugins/android/androidconfigurations.cpp
+++ b/src/plugins/android/androidconfigurations.cpp
@@ -1169,7 +1169,7 @@ void AndroidConfigurations::removeUnusedDebuggers()
             uniqueNdks.append(ndkLocation);
     }
 
-    uniqueNdks.append(FileUtils::toFilePathList(currentConfig().getCustomNdkList()).toVector());
+    uniqueNdks.append(FileUtils::toFilePathList(currentConfig().getCustomNdkList()));
 
     const QList<Debugger::DebuggerItem> allDebuggers = Debugger::DebuggerItemManager::debuggers();
     for (const Debugger::DebuggerItem &debugger : allDebuggers) {
diff --git a/src/plugins/clangtools/clangtoolsutils.cpp b/src/plugins/clangtools/clangtoolsutils.cpp
index acfd768797b..2fad633bfaf 100644
--- a/src/plugins/clangtools/clangtoolsutils.cpp
+++ b/src/plugins/clangtools/clangtoolsutils.cpp
@@ -294,7 +294,7 @@ QStringList extraClangToolsPrependOptions()
     static const QStringList options = extraOptions(csaPrependOptions)
                                        + extraOptions(toolsPrependOptions);
     if (!options.isEmpty())
-        qWarning() << "ClangTools options are prepended with " << options.toVector();
+        qWarning() << "ClangTools options are prepended with " << options;
     return options;
 }
 
@@ -305,7 +305,7 @@ QStringList extraClangToolsAppendOptions()
     static const QStringList options = extraOptions(csaAppendOptions)
                                        + extraOptions(toolsAppendOptions);
     if (!options.isEmpty())
-        qWarning() << "ClangTools options are appended with " << options.toVector();
+        qWarning() << "ClangTools options are appended with " << options;
     return options;
 }
 
diff --git a/src/plugins/languageclient/locatorfilter.cpp b/src/plugins/languageclient/locatorfilter.cpp
index f8b14f04bf6..6eca624ae0d 100644
--- a/src/plugins/languageclient/locatorfilter.cpp
+++ b/src/plugins/languageclient/locatorfilter.cpp
@@ -301,7 +301,7 @@ void WorkspaceLocatorFilter::handleResponse(Client *client,
     auto result = response.result().value_or(LanguageClientArray<SymbolInformation>());
     if (!result.isNull())
         m_results.append(
-            Utils::transform(result.toList().toVector(), [client](const SymbolInformation &info) {
+            Utils::transform(result.toList(), [client](const SymbolInformation &info) {
                 return SymbolInfoWithPathMapper{info, client->hostPathMapper()};
             }));
     if (m_pendingRequests.isEmpty())
diff --git a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
index 7aaed70c9dd..406a7a295d1 100644
--- a/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
+++ b/src/plugins/qmldesigner/designercore/instances/nodeinstanceview.cpp
@@ -870,7 +870,7 @@ NodeInstance NodeInstanceView::activeStateInstance() const
 
 void NodeInstanceView::updateChildren(const NodeAbstractProperty &newPropertyParent)
 {
-    const QVector<ModelNode> childNodeVector = newPropertyParent.directSubNodes().toVector();
+    const QList<ModelNode> childNodeVector = newPropertyParent.directSubNodes();
 
     qint32 parentInstanceId = newPropertyParent.parentModelNode().internalId();
 
@@ -1506,7 +1506,7 @@ void NodeInstanceView::pixmapChanged(const PixmapChangedCommand &command)
     m_nodeInstanceServer->benchmark(Q_FUNC_INFO + QString::number(renderImageChangeSet.count()));
 
     if (!renderImageChangeSet.isEmpty())
-        emitInstancesRenderImageChanged(Utils::toList(renderImageChangeSet).toVector());
+        emitInstancesRenderImageChanged(Utils::toList(renderImageChangeSet));
 
     if (!containerVector.isEmpty()) {
         QMultiHash<ModelNode, InformationName> informationChangeHash = informationChanged(