From f112f83511d35d1ccfc0d29b4f989c1c5f95e2c3 Mon Sep 17 00:00:00 2001 From: Samuel Gaist Date: Fri, 10 Mar 2023 09:34:01 +0100 Subject: [PATCH] GitLab plugin: Remove visibility public default value The query currently used does not provide this value and showing public for everything is misleading to the users. Fixes: QTCREATORBUG-28882 Change-Id: Ie47a4fa24e4b1e90b8d1a53c5819742f2b5aca71 Reviewed-by: Christian Stenger --- src/plugins/gitlab/gitlabdialog.cpp | 2 +- src/plugins/gitlab/resultparser.cpp | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/plugins/gitlab/gitlabdialog.cpp b/src/plugins/gitlab/gitlabdialog.cpp index 97d57e42651..4a10888c944 100644 --- a/src/plugins/gitlab/gitlabdialog.cpp +++ b/src/plugins/gitlab/gitlabdialog.cpp @@ -338,7 +338,7 @@ void GitLabDialog::handleProjects(const Projects &projects) // TODO use a real model / delegate..? listModel->setDataAccessor([](Project *data, int /*column*/, int role) -> QVariant { if (role == Qt::DisplayRole) - return QString(data->displayName + " (" + data->visibility + ')'); + return data->displayName; if (role == Qt::UserRole) return QVariant::fromValue(*data); return QVariant(); diff --git a/src/plugins/gitlab/resultparser.cpp b/src/plugins/gitlab/resultparser.cpp index 80fe316013b..e2497c8bf1f 100644 --- a/src/plugins/gitlab/resultparser.cpp +++ b/src/plugins/gitlab/resultparser.cpp @@ -144,7 +144,7 @@ static Project projectFromJson(const QJsonObject &jsonObj) project.displayName = jsonObj.value("name_with_namespace").toString(); project.pathName = jsonObj.value("path_with_namespace").toString(); project.id = jsonObj.value("id").toInt(-1); - project.visibility = jsonObj.value("visibility").toString("public"); + project.visibility = jsonObj.value("visibility").toString(); project.httpUrl = jsonObj.value("http_url_to_repo").toString(); project.sshUrl = jsonObj.value("ssh_url_to_repo").toString(); if (jsonObj.contains("forks_count"))