feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ImageContainer: Fix potential use after free

Browse Source 
Found during clang-analyzer run.

Change-Id: I6549403ac949650058348ccc22b2020d09ef53e0
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Marcus Tillmanns
2022-05-17 13:16:50 +02:00
parent f54097fefb
commit f117c2a37b
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
share/qtcreator/qml/qmlpuppet/container/imagecontainer.cpp
View File

@@ -98,7 +98,8 @@ static SharedMemory *createSharedMemory(qint32 key, int byteCount)
sharedMemory = new SharedMemory(QString(imageKeyTemplateString).arg(key));
bool sharedMemoryIsCreated = sharedMemory->create(byteCount);
if (sharedMemoryIsCreated) {
globalSharedMemoryContainer()->insert(key, sharedMemory);
if (!globalSharedMemoryContainer()->insert(key, sharedMemory))
return nullptr;
} else {
delete sharedMemory;
sharedMemory = nullptr;