feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Project: Get rid of builddirectoryChanged signal

Browse Source 
Get rid of Project::buildDirectoryChanged signal as well as
Target::buildDirectoryChanged (and the infrastructure).

Change-Id: Ia749e62eec7e182e558d81115dc2a3d07b72b346
Reviewed-by: Tim Jenssen <tim.jenssen@qt.io>
This commit is contained in:
Tobias Hunger
2017-07-31 13:07:44 +02:00
parent 4a40a18c05
commit f119eec4d1
7 changed files with 9 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/plugins/projectexplorer/target.cpp
View File

@@ -174,13 +174,6 @@ void Target::changeRunConfigurationEnabled()
emit runConfigurationEnabledChanged();
}
void Target::onBuildDirectoryChanged()
{
auto bc = qobject_cast<BuildConfiguration *>(sender());
if (bc && activeBuildConfiguration() == bc)
emit buildDirectoryChanged();
}
void Target::handleKitUpdates(Kit *k)
{
if (k != d->m_kit)
@@ -241,8 +234,6 @@ void Target::addBuildConfiguration(BuildConfiguration *bc)
connect(bc, &BuildConfiguration::enabledChanged,
this, &Target::changeBuildConfigurationEnabled);
connect(bc, &BuildConfiguration::buildDirectoryChanged,
this, &Target::onBuildDirectoryChanged);
if (!activeBuildConfiguration())
setActiveBuildConfiguration(bc);
@@ -295,7 +286,6 @@ void Target::setActiveBuildConfiguration(BuildConfiguration *bc)
emit activeProjectConfigurationChanged(d->m_activeBuildConfiguration);
emit activeBuildConfigurationChanged(d->m_activeBuildConfiguration);
emit buildConfigurationEnabledChanged();
emit buildDirectoryChanged();
}
}