diff --git a/src/plugins/cmakeprojectmanager/servermodereader.cpp b/src/plugins/cmakeprojectmanager/servermodereader.cpp index 5c0a39e7696..345dc0e40f9 100644 --- a/src/plugins/cmakeprojectmanager/servermodereader.cpp +++ b/src/plugins/cmakeprojectmanager/servermodereader.cpp @@ -538,11 +538,8 @@ void ServerModeReader::extractCacheData(const QVariantMap &data) m_cmakeCache = config; } -QSet ServerModeReader::updateCMakeLists(CMakeListsNode *root, - const QList &cmakeLists) +void ServerModeReader::updateCMakeLists(CMakeListsNode *root, const QList &cmakeLists) { - QSet usedNodes; - const QDir baseDir = QDir(m_parameters.sourceDirectory.toString()); QHash nodeHash; @@ -588,8 +585,6 @@ QSet ServerModeReader::updateCMakeLists(CMakeListsNode *root, cmFn = fn; cmln->addFileNodes({ cmFn }); } - usedNodes.insert(cmFn); // register existing CMakeLists.txt filenode - // Update displayName of CMakeListsNode: const QString dn = prefix.isEmpty() ? k : k.mid(prefix.count() + 1); if (!dn.isEmpty()) @@ -597,8 +592,6 @@ QSet ServerModeReader::updateCMakeLists(CMakeListsNode *root, knownNodes.insert(k, cmln); } - - return usedNodes; } static CMakeListsNode *findCMakeNode(CMakeListsNode *root, const Utils::FileName &dir) @@ -649,12 +642,10 @@ static CMakeProjectNode *findOrCreateProjectNode(CMakeListsNode *root, const Uti return pn; } -QSet ServerModeReader::updateProjects(CMakeListsNode *root, - const QList &projects, - const QList &allFiles) +void ServerModeReader::updateProjects(CMakeListsNode *root, + const QList &projects, + const QList &allFiles) { - QSet usedNodes; - QHash> includeFiles; for (const FileNode *f : allFiles) { if (f->fileType() != FileType::Header) @@ -665,11 +656,8 @@ QSet ServerModeReader::updateProjects(CMakeListsNode *root, for (const Project *p : projects) { CMakeProjectNode *pNode = findOrCreateProjectNode(root, p->sourceDirectory, p->name); QTC_ASSERT(pNode, continue); - usedNodes.insert(pNode); // Mark as leaf to keep. - - usedNodes.unite(updateTargets(root, p->targets, includeFiles)); + updateTargets(root, p->targets, includeFiles); } - return usedNodes; } static CMakeTargetNode *findOrCreateTargetNode(CMakeListsNode *root, const Utils::FileName &dir, @@ -690,19 +678,15 @@ static CMakeTargetNode *findOrCreateTargetNode(CMakeListsNode *root, const Utils return tn; } -QSet ServerModeReader::updateTargets(CMakeListsNode *root, +void ServerModeReader::updateTargets(CMakeListsNode *root, const QList &targets, const QHash> &headers) { - QSet usedNodes; for (const Target *t : targets) { CMakeTargetNode *tNode = findOrCreateTargetNode(root, t->sourceDirectory, t->name); tNode->setTargetInformation(t->artifacts, t->type); - usedNodes.insert(tNode); // always keep the target node: FileGroups use buildTree! - updateFileGroups(tNode, t->sourceDirectory, t->buildDirectory, t->fileGroups, headers); } - return usedNodes; } void ServerModeReader::updateFileGroups(ProjectNode *targetRoot, diff --git a/src/plugins/cmakeprojectmanager/servermodereader.h b/src/plugins/cmakeprojectmanager/servermodereader.h index 9a9812a50eb..dc0231328b3 100644 --- a/src/plugins/cmakeprojectmanager/servermodereader.h +++ b/src/plugins/cmakeprojectmanager/servermodereader.h @@ -119,14 +119,11 @@ private: void extractCMakeInputsData(const QVariantMap &data); void extractCacheData(const QVariantMap &data); - QSet updateCMakeLists(CMakeListsNode *root, - const QList &cmakeLists); - QSet updateProjects(CMakeListsNode *root, - const QList &projects, - const QList &allFiles); - QSet updateTargets(CMakeListsNode *root, - const QList &targets, - const QHash> &headers); + void updateCMakeLists(CMakeListsNode *root, const QList &cmakeLists); + void updateProjects(CMakeListsNode *root, const QList &projects, + const QList &allFiles); + void updateTargets(CMakeListsNode *root, const QList &targets, + const QHash> &headers); void updateFileGroups(ProjectExplorer::ProjectNode *targetRoot, const Utils::FileName &sourceDirectory, const Utils::FileName &buildDirectory,