diff --git a/src/plugins/android/CMakeLists.txt b/src/plugins/android/CMakeLists.txt index 94a52d5148e..60b549a7f2a 100644 --- a/src/plugins/android/CMakeLists.txt +++ b/src/plugins/android/CMakeLists.txt @@ -27,7 +27,6 @@ add_qtc_plugin(Android androidqmltoolingsupport.cpp androidqmltoolingsupport.h androidqtversion.cpp androidqtversion.h androidrunconfiguration.cpp androidrunconfiguration.h - androidruncontrol.cpp androidruncontrol.h androidrunner.cpp androidrunner.h androidrunnerworker.cpp androidrunnerworker.h androidsdkdownloader.cpp androidsdkdownloader.h diff --git a/src/plugins/android/android.qbs b/src/plugins/android/android.qbs index de16bda375c..6618e7c9cfb 100644 --- a/src/plugins/android/android.qbs +++ b/src/plugins/android/android.qbs @@ -55,8 +55,6 @@ QtcPlugin { "androidqtversion.h", "androidrunconfiguration.cpp", "androidrunconfiguration.h", - "androidruncontrol.cpp", - "androidruncontrol.h", "androidrunner.cpp", "androidrunner.h", "androidrunnerworker.cpp", diff --git a/src/plugins/android/androidplugin.cpp b/src/plugins/android/androidplugin.cpp index 5f860134f8f..232a3e5f590 100644 --- a/src/plugins/android/androidplugin.cpp +++ b/src/plugins/android/androidplugin.cpp @@ -13,7 +13,7 @@ #include "androidqmltoolingsupport.h" #include "androidqtversion.h" #include "androidrunconfiguration.h" -#include "androidruncontrol.h" +#include "androidrunner.h" #include "androidsettingswidget.h" #include "androidtoolchain.h" #include "androidtr.h" diff --git a/src/plugins/android/androidruncontrol.cpp b/src/plugins/android/androidruncontrol.cpp deleted file mode 100644 index 023e14525c3..00000000000 --- a/src/plugins/android/androidruncontrol.cpp +++ /dev/null @@ -1,53 +0,0 @@ -// Copyright (C) 2016 BogDan Vatra -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 - -#include "androidruncontrol.h" - -#include "androidconstants.h" -#include "androidglobal.h" -#include "androidrunconfiguration.h" -#include "androidrunner.h" - -#include - -#include - -using namespace ProjectExplorer; - -namespace Android::Internal { - -class AndroidRunSupport final : public AndroidRunner -{ -public: - explicit AndroidRunSupport(RunControl *runControl); - ~AndroidRunSupport() override; -}; - -AndroidRunSupport::AndroidRunSupport(RunControl *runControl) - : AndroidRunner(runControl) -{ - runControl->setIcon(Utils::Icons::RUN_SMALL_TOOLBAR); -} - -AndroidRunSupport::~AndroidRunSupport() -{ - stop(); -} - -class AndroidRunWorkerFactory final : public RunWorkerFactory -{ -public: - AndroidRunWorkerFactory() - { - setProduct(); - addSupportedRunMode(ProjectExplorer::Constants::NORMAL_RUN_MODE); - addSupportedRunConfig(Constants::ANDROID_RUNCONFIG_ID); - } -}; - -void setupAndroidRunWorker() -{ - static AndroidRunWorkerFactory theAndroidRunWorkerFactory; -} - -} // Android::Internal diff --git a/src/plugins/android/androidruncontrol.h b/src/plugins/android/androidruncontrol.h deleted file mode 100644 index 9c6fee8f251..00000000000 --- a/src/plugins/android/androidruncontrol.h +++ /dev/null @@ -1,10 +0,0 @@ -// Copyright (C) 2016 BogDan Vatra -// SPDX-License-Identifier: LicenseRef-Qt-Commercial OR GPL-3.0-only WITH Qt-GPL-exception-1.0 - -#pragma once - -namespace Android::Internal { - -void setupAndroidRunWorker(); - -} // Android::Internal diff --git a/src/plugins/android/androidrunner.cpp b/src/plugins/android/androidrunner.cpp index f5febfc275a..b72ab54f477 100644 --- a/src/plugins/android/androidrunner.cpp +++ b/src/plugins/android/androidrunner.cpp @@ -5,6 +5,7 @@ #include "androidrunner.h" #include "androidavdmanager.h" +#include "androidconstants.h" #include "androiddevice.h" #include "androidmanager.h" #include "androidrunnerworker.h" @@ -12,8 +13,11 @@ #include #include + #include + #include +#include #include #include @@ -31,6 +35,7 @@ namespace Android::Internal { AndroidRunner::AndroidRunner(RunControl *runControl) : RunWorker(runControl) { + runControl->setIcon(Utils::Icons::RUN_SMALL_TOOLBAR); setId("AndroidRunner"); static const int metaTypes[] = { qRegisterMetaType>("QList"), @@ -152,4 +157,20 @@ void AndroidRunner::remoteStdErr(const QString &output) m_outputParser.processOutput(output); } +class AndroidRunWorkerFactory final : public RunWorkerFactory +{ +public: + AndroidRunWorkerFactory() + { + setProduct(); + addSupportedRunMode(ProjectExplorer::Constants::NORMAL_RUN_MODE); + addSupportedRunConfig(Constants::ANDROID_RUNCONFIG_ID); + } +}; + +void setupAndroidRunWorker() +{ + static AndroidRunWorkerFactory theAndroidRunWorkerFactory; +} + } // namespace Android::Internal diff --git a/src/plugins/android/androidrunner.h b/src/plugins/android/androidrunner.h index 7ec2babb7b0..748b3879d00 100644 --- a/src/plugins/android/androidrunner.h +++ b/src/plugins/android/androidrunner.h @@ -48,4 +48,6 @@ private: Tasking::TaskTreeRunner m_taskTreeRunner; }; +void setupAndroidRunWorker(); + } // namespace Android::Internal