Gerrit: Add 'Details' text to dialog.

- Add a splitter and a text browser containing detailed text
  for the change using HTML links for email and URL, allowing
  for removal of 'Open', 'Copy URL' buttons.
- Remove large tooltip from list, rename methods to toHtml()
  and use them for the details text.
- Parse out reviewer email.
- Display approval level with sign.

Change-Id: I2d71a80bbe19643e5bfa9deeaaeb3650976f00b4
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
Reviewed-by: Tobias Hunger <tobias.hunger@nokia.com>
This commit is contained in:
Friedemann Kleint
2012-05-16 16:31:58 +02:00
parent 6e224d502d
commit f1b52256cd
4 changed files with 77 additions and 53 deletions

View File

@@ -38,11 +38,13 @@
QT_BEGIN_NAMESPACE
class QTreeView;
class QLabel;
class QModelIndex;
class QSortFilterProxyModel;
class QStandardItem;
class QPushButton;
class QDialogButtonBox;
class QTextBrowser;
QT_END_NAMESPACE
namespace Utils {
@@ -68,18 +70,15 @@ signals:
void fetchCheckout(const QSharedPointer<Gerrit::Internal::GerritChange> &);
private slots:
void slotEnableButtons();
void slotCurrentChanged();
void slotDoubleClicked(const QModelIndex &);
void slotRefreshStateChanged(bool);
void slotOpenBrowser();
void slotFetchDisplay();
void slotFetchApply();
void slotFetchCheckout();
void slotCopyUrl();
void slotRefresh();
private:
inline void openUrl(int row) const;
const QStandardItem *itemAt(const QModelIndex &i, int column = 0) const;
const QStandardItem *currentItem(int column = 0) const;
QPushButton *addActionButton(const QString &text, const char *buttonSlot);
@@ -88,13 +87,12 @@ private:
QSortFilterProxyModel *m_filterModel;
GerritModel *m_model;
QTreeView *m_treeView;
QTextBrowser *m_detailsBrowser;
Utils::FilterLineEdit *m_filterLineEdit;
QDialogButtonBox *m_buttonBox;
QPushButton *m_openButton;
QPushButton *m_displayButton;
QPushButton *m_applyButton;
QPushButton *m_checkoutButton;
QPushButton *m_copyUrlButton;
QPushButton *m_refreshButton;
};