feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Add interface to check incompatible qml ids

Browse Source 
Task-number: QDS-10121
Change-Id: I112bee4e9323dc4eff30ec7a4693c1e9632d6ba9
Reviewed-by: Qt CI Patch Build Bot <ci_patchbuild_bot@qt.io>
Reviewed-by: Thomas Hartmann <thomas.hartmann@qt.io>
This commit is contained in:
Vikas Pachdha
2023-07-19 14:10:12 +02:00
parent 655ec9d948
commit f1b5fb6e11
2 changed files with 7 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

7
src/libs/qmljs/qmljscheck.cpp
View File

@@ -680,6 +680,11 @@ QList<StaticAnalysis::Type> Check::defaultDisabledMessagesForNonQuickUi()
return disabled; return disabled;
} }
bool Check::incompatibleDesignerQmlId(const QString &id)
{
return idsThatShouldNotBeUsedInDesigner->contains(id);
}
Check::Check(Document::Ptr doc, const ContextPtr &context, Utils::QtcSettings *qtcSettings) Check::Check(Document::Ptr doc, const ContextPtr &context, Utils::QtcSettings *qtcSettings)
: _doc(doc) : _doc(doc)
, _context(context) , _context(context)
@@ -1099,7 +1104,7 @@ bool Check::visit(UiScriptBinding *ast)
return false; return false;
} }
if (idsThatShouldNotBeUsedInDesigner->contains(id)) { if (incompatibleDesignerQmlId(id)) {
addMessage(ErrInvalidIdeInVisualDesigner, loc); addMessage(ErrInvalidIdeInVisualDesigner, loc);
} }

1
src/libs/qmljs/qmljscheck.h
View File

@@ -39,6 +39,7 @@ public:
static QList<StaticAnalysis::Type> defaultDisabledMessages(); static QList<StaticAnalysis::Type> defaultDisabledMessages();
static QList<StaticAnalysis::Type> defaultDisabledMessagesForNonQuickUi(); static QList<StaticAnalysis::Type> defaultDisabledMessagesForNonQuickUi();
static bool incompatibleDesignerQmlId(const QString &id);
protected: protected:
bool preVisit(AST::Node *ast) override; bool preVisit(AST::Node *ast) override;