feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Valgrind: Remove MemcheckRunner::localHostAddressRetrieved() etc

Browse Source 
It was only ever used to run second valgrindProcess()->setValgrindArguments
(fullValgrindArguments()) in the memcheck tool which was already done in
ValgrindRunner::start()

Change-Id: I95a6005e2131eea25215f17cd0e7244a3d8df12e
Reviewed-by: Christian Kandeler <christian.kandeler@theqtcompany.com>
This commit is contained in:
hjk
2016-02-02 16:23:51 +01:00
committed by Christian Kandeler
parent f4296d7504
commit f1ccad12dc
6 changed files with 0 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
src/plugins/valgrind/memcheck/memcheckrunner.cpp
View File

@@ -172,11 +172,5 @@ QStringList MemcheckRunner::memcheckLogArguments() const
return arguments; return arguments;
} }
void MemcheckRunner::localHostAddressRetrieved(const QHostAddress &localHostAddress)
{
Q_UNUSED(localHostAddress);
valgrindProcess()->setValgrindArguments(fullValgrindArguments());
}
} // namespace Memcheck } // namespace Memcheck
} // namespace Valgrind } // namespace Valgrind

2
src/plugins/valgrind/memcheck/memcheckrunner.h
View File

@@ -53,8 +53,6 @@ signals:
void logMessageReceived(const QByteArray &); void logMessageReceived(const QByteArray &);
private slots: private slots:
void localHostAddressRetrieved(const QHostAddress &localHostAddress);
void xmlSocketConnected(); void xmlSocketConnected();
void logSocketConnected(); void logSocketConnected();
void readLogSocket(); void readLogSocket();

2
src/plugins/valgrind/valgrindprocess.cpp
View File

@@ -205,8 +205,6 @@ void ValgrindProcess::connected()
{ {
QTC_ASSERT(m_remote.m_connection->state() == QSsh::SshConnection::Connected, return); QTC_ASSERT(m_remote.m_connection->state() == QSsh::SshConnection::Connected, return);
emit localHostAddressRetrieved(m_remote.m_connection->connectionInfo().localAddress);
// connected, run command // connected, run command
QString cmd; QString cmd;

1
src/plugins/valgrind/valgrindprocess.h
View File

@@ -75,7 +75,6 @@ signals:
void finished(int, QProcess::ExitStatus); void finished(int, QProcess::ExitStatus);
void error(QProcess::ProcessError); void error(QProcess::ProcessError);
void processOutput(const QString &, Utils::OutputFormat format); void processOutput(const QString &, Utils::OutputFormat format);
void localHostAddressRetrieved(const QHostAddress &localHostAddress);
private: private:
void handleRemoteStderr(); void handleRemoteStderr();

7
src/plugins/valgrind/valgrindrunner.cpp
View File

@@ -147,8 +147,6 @@ bool ValgrindRunner::start()
this, &ValgrindRunner::processFinished); this, &ValgrindRunner::processFinished);
QObject::connect(d->process, &ValgrindProcess::error, QObject::connect(d->process, &ValgrindProcess::error,
this, &ValgrindRunner::processError); this, &ValgrindRunner::processError);
QObject::connect(d->process, &ValgrindProcess::localHostAddressRetrieved,
this, &ValgrindRunner::localHostAddressRetrieved);
d->process->run(); d->process->run();
return true; return true;
@@ -180,11 +178,6 @@ void ValgrindRunner::processFinished(int ret, QProcess::ExitStatus status)
emit processErrorReceived(errorString(), d->process->processError()); emit processErrorReceived(errorString(), d->process->processError());
} }
void ValgrindRunner::localHostAddressRetrieved(const QHostAddress &localHostAddress)
{
Q_UNUSED(localHostAddress);
}
QString ValgrindRunner::errorString() const QString ValgrindRunner::errorString() const
{ {
if (d->process) if (d->process)

1
src/plugins/valgrind/valgrindrunner.h
View File

@@ -80,7 +80,6 @@ signals:
protected slots: protected slots:
virtual void processError(QProcess::ProcessError); virtual void processError(QProcess::ProcessError);
virtual void processFinished(int, QProcess::ExitStatus); virtual void processFinished(int, QProcess::ExitStatus);
virtual void localHostAddressRetrieved(const QHostAddress &localHostAddress);
private: private:
class Private; class Private;