From f1f506b47970b746d472acb65eb94014f9fafe33 Mon Sep 17 00:00:00 2001
From: Orgad Shaneh <orgad.shaneh@audiocodes.com>
Date: Tue, 28 Aug 2018 00:00:16 +0300
Subject: [PATCH] VCS: Remove unused unregisterActions functions
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Change-Id: I4c7a0dfc93f27f93cdbd84d7e027e63db05341e8
Reviewed-by: André Hartmann <aha_1980@gmx.de>
Reviewed-by: Tobias Hunger <tobias.hunger@qt.io>
---
 src/plugins/vcsbase/submiteditorwidget.cpp  | 31 ---------------------
 src/plugins/vcsbase/submiteditorwidget.h    |  2 --
 src/plugins/vcsbase/vcsbasesubmiteditor.cpp |  7 -----
 src/plugins/vcsbase/vcsbasesubmiteditor.h   |  2 --
 4 files changed, 42 deletions(-)

diff --git a/src/plugins/vcsbase/submiteditorwidget.cpp b/src/plugins/vcsbase/submiteditorwidget.cpp
index d9b7125e772..0f453a2747a 100644
--- a/src/plugins/vcsbase/submiteditorwidget.cpp
+++ b/src/plugins/vcsbase/submiteditorwidget.cpp
@@ -250,37 +250,6 @@ void SubmitEditorWidget::registerActions(QAction *editorUndoAction, QAction *edi
     }
 }
 
-void SubmitEditorWidget::unregisterActions(QAction *editorUndoAction,  QAction *editorRedoAction,
-                                           QAction *submitAction, QAction *diffAction)
-{
-    if (editorUndoAction) {
-        disconnect(d->m_ui.description, &CompletingTextEdit::undoAvailable,
-                   editorUndoAction, &QAction::setEnabled);
-        disconnect(editorUndoAction, &QAction::triggered,
-                   d->m_ui.description, &CompletingTextEdit::undo);
-    }
-    if (editorRedoAction) {
-        disconnect(d->m_ui.description, &CompletingTextEdit::redoAvailable,
-                   editorRedoAction, &QAction::setEnabled);
-        disconnect(editorRedoAction, &QAction::triggered,
-                   d->m_ui.description, &CompletingTextEdit::redo);
-    }
-
-    if (submitAction) {
-        disconnect(this, &SubmitEditorWidget::submitActionEnabledChanged,
-                   submitAction, &QAction::setEnabled);
-        // Just deactivate the QActionSetTextSlotHelper on the action
-        disconnect(this, &SubmitEditorWidget::submitActionTextChanged, 0, 0);
-    }
-
-    if (diffAction) {
-         disconnect(this, &SubmitEditorWidget::fileSelectionChanged,
-                    diffAction, &QAction::setEnabled);
-         disconnect(diffAction, &QAction::triggered,
-                    this, &SubmitEditorWidget::triggerDiffSelected);
-    }
-}
-
 // Make sure we have one terminating NL. Do not trim front as leading space might be
 // required for some formattings.
 void SubmitEditorWidget::trimDescription()
diff --git a/src/plugins/vcsbase/submiteditorwidget.h b/src/plugins/vcsbase/submiteditorwidget.h
index 2d46852e2ca..da73f2d96d0 100644
--- a/src/plugins/vcsbase/submiteditorwidget.h
+++ b/src/plugins/vcsbase/submiteditorwidget.h
@@ -60,8 +60,6 @@ public:
     // be updated.
     void registerActions(QAction *editorUndoAction,  QAction *editorRedoAction,
                          QAction *submitAction = nullptr, QAction *diffAction = nullptr);
-    void unregisterActions(QAction *editorUndoAction,  QAction *editorRedoAction,
-                           QAction *submitAction = nullptr, QAction *diffAction = nullptr);
 
     QString descriptionText() const;
     void setDescriptionText(const QString &text);
diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
index 02a4b4783fd..2a3590784bf 100644
--- a/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
+++ b/src/plugins/vcsbase/vcsbasesubmiteditor.cpp
@@ -310,13 +310,6 @@ void VcsBaseSubmitEditor::registerActions(QAction *editorUndoAction, QAction *ed
     d->m_submitAction = submitAction;
 }
 
-void VcsBaseSubmitEditor::unregisterActions(QAction *editorUndoAction,  QAction *editorRedoAction,
-                           QAction *submitAction, QAction *diffAction)
-{
-    d->m_widget->unregisterActions(editorUndoAction, editorRedoAction, submitAction, diffAction);
-    d->m_diffAction = d->m_submitAction = 0;
-}
-
 QAbstractItemView::SelectionMode VcsBaseSubmitEditor::fileListSelectionMode() const
 {
     return d->m_widget->fileListSelectionMode();
diff --git a/src/plugins/vcsbase/vcsbasesubmiteditor.h b/src/plugins/vcsbase/vcsbasesubmiteditor.h
index 2d386d79d01..8d1b3104c12 100644
--- a/src/plugins/vcsbase/vcsbasesubmiteditor.h
+++ b/src/plugins/vcsbase/vcsbasesubmiteditor.h
@@ -74,8 +74,6 @@ public:
     // Register the actions with the submit editor widget.
     void registerActions(QAction *editorUndoAction,  QAction *editorRedoAction,
                          QAction *submitAction = nullptr, QAction *diffAction = nullptr);
-    void unregisterActions(QAction *editorUndoAction,  QAction *editorRedoAction,
-                           QAction *submitAction = nullptr, QAction *diffAction = nullptr);
 
     ~VcsBaseSubmitEditor() override;