feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Build: Optionally sign on Windows

Browse Source 
Add an argument to the build script that takes a signing command (path
to sign is added at the end, run in cwd)

Task-number: QTCREATORBUG-25740
Task-number: QTCREATORBUG-28909
Change-Id: I6d3bdf7bd9fab0ea1fc129da08cf77c9a5448b31
Reviewed-by: Cristian Adam <cristian.adam@qt.io>
Reviewed-by: <github-actions-qt-creator@cristianadam.eu>
This commit is contained in:
Eike Ziller
2023-03-17 13:00:34 +01:00
parent 584874f15f
commit f1fde363a0
2 changed files with 18 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
scripts/build.py
View File

@@ -8,6 +8,7 @@ from __future__ import print_function
import argparse import argparse
import collections import collections
import os import os
import shlex
import shutil import shutil
import common import common
@@ -43,6 +44,8 @@ def get_arguments():
# signing # signing
parser.add_argument('--keychain-unlock-script', parser.add_argument('--keychain-unlock-script',
help='Path to script for unlocking the keychain used for signing (macOS)') help='Path to script for unlocking the keychain used for signing (macOS)')
parser.add_argument('--sign-command',
help='Command to use for signing (Windows). The installation directory to sign is added at the end. Is run in the CWD.')
# cdbextension # cdbextension
parser.add_argument('--python-path', parser.add_argument('--python-path',
@@ -262,6 +265,14 @@ def zipPatternForApp(paths):
def package_qtcreator(args, paths): def package_qtcreator(args, paths):
if common.is_windows_platform() and args.sign_command:
command = shlex.split(args.sign_command)
if not args.no_qtcreator:
common.check_print_call(command + [paths.install])
common.check_print_call(command + [paths.wininterrupt_install])
if not args.no_cdb:
common.check_print_call(command + [paths.qtcreatorcdbext_install])
if not args.no_zip: if not args.no_zip:
if not args.no_qtcreator: if not args.no_qtcreator:
common.check_print_call(['7z', 'a', '-mmt' + args.zip_threads, common.check_print_call(['7z', 'a', '-mmt' + args.zip_threads,

7
scripts/build_plugin.py
View File

@@ -9,6 +9,7 @@ import argparse
import collections import collections
import glob import glob
import os import os
import shlex
import common import common
@@ -46,6 +47,9 @@ def get_arguments():
# signing # signing
parser.add_argument('--keychain-unlock-script', parser.add_argument('--keychain-unlock-script',
help='Path to script for unlocking the keychain used for signing (macOS)') help='Path to script for unlocking the keychain used for signing (macOS)')
parser.add_argument('--sign-command',
help='Command to use for signing (Windows). The installation directory to sign is added at the end. Is run in the CWD.')
args = parser.parse_args() args = parser.parse_args()
args.with_debug_info = args.build_type == 'RelWithDebInfo' args.with_debug_info = args.build_type == 'RelWithDebInfo'
return args return args
@@ -140,6 +144,9 @@ def build(args, paths):
def package(args, paths): def package(args, paths):
if not os.path.exists(paths.result): if not os.path.exists(paths.result):
os.makedirs(paths.result) os.makedirs(paths.result)
if common.is_windows_platform() and args.sign_command:
command = shlex.split(args.sign_command)
common.check_print_call(command + [paths.install])
common.check_print_call(['7z', 'a', '-mmt2', os.path.join(paths.result, args.name + '.7z'), '*'], common.check_print_call(['7z', 'a', '-mmt2', os.path.join(paths.result, args.name + '.7z'), '*'],
paths.install) paths.install)
if os.path.exists(paths.dev_install): # some plugins might not provide anything in Devel if os.path.exists(paths.dev_install): # some plugins might not provide anything in Devel