feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

DocumentClangToolRunner: Delete later the old runner on runNext()

Browse Source 
Don't delete the old ClangToolRunner directly from its signal
handler when calling runNext().

Change-Id: I55e72c1cced9ecbce492d00896d6fa161df02fd0
Reviewed-by: David Schulz <david.schulz@qt.io>
This commit is contained in:
Jarek Kobus
2022-06-16 17:27:47 +02:00
parent f873ad1cf0
commit f1ff0a90e0
1 changed files with 2 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
src/plugins/clangtools/documentclangtoolrunner.cpp
View File

@@ -251,6 +251,8 @@ QPair<FilePath, QString> getClangIncludeDirAndVersion(ClangToolRunner *runner)
void DocumentClangToolRunner::runNext() void DocumentClangToolRunner::runNext()
{ {
if (m_currentRunner)
m_currentRunner.release()->deleteLater();
m_currentRunner.reset(m_runnerCreators.isEmpty() ? nullptr : m_runnerCreators.takeFirst()()); m_currentRunner.reset(m_runnerCreators.isEmpty() ? nullptr : m_runnerCreators.takeFirst()());
if (m_currentRunner) { if (m_currentRunner) {
auto [clangIncludeDir, clangVersion] = getClangIncludeDirAndVersion(m_currentRunner.get()); auto [clangIncludeDir, clangVersion] = getClangIncludeDirAndVersion(m_currentRunner.get());