feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

ProjectExplorer: Simplify KitManagerPrivate access

Browse Source 
Change-Id: Ia4e97a93899c7cd90d97a4cfaa6098cd2b395cc8
Reviewed-by: Jarek Kobus <jaroslaw.kobus@qt.io>
This commit is contained in:
hjk
2023-08-16 08:33:06 +02:00
parent fa011af1a0
commit f21282cb2d
1 changed files with 3 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
src/plugins/projectexplorer/kitmanager.cpp
View File

@@ -113,11 +113,6 @@ public:
std::vector<std::unique_ptr<Kit>> m_kitList; std::vector<std::unique_ptr<Kit>> m_kitList;
std::unique_ptr<PersistentSettingsWriter> m_writer; std::unique_ptr<PersistentSettingsWriter> m_writer;
QSet<Id> m_irrelevantAspects; QSet<Id> m_irrelevantAspects;
void setBinaryForKit(const FilePath &fp) { m_binaryForKit = fp; }
FilePath binaryForKit() const { return m_binaryForKit; }
private:
FilePath m_binaryForKit; FilePath m_binaryForKit;
}; };
@@ -243,8 +238,8 @@ void KitManager::restoreKits()
return false; return false;
}; };
const Abis abisOfBinary = d->binaryForKit().isEmpty() const Abis abisOfBinary = d->m_binaryForKit.isEmpty()
? Abis() : Abi::abisOfBinary(d->binaryForKit()); ? Abis() : Abi::abisOfBinary(d->m_binaryForKit);
const auto kitMatchesAbiOfBinary = [&abisOfBinary](const Kit *kit) { const auto kitMatchesAbiOfBinary = [&abisOfBinary](const Kit *kit) {
return kitMatchesAbiList(kit, abisOfBinary); return kitMatchesAbiList(kit, abisOfBinary);
}; };
@@ -463,7 +458,7 @@ bool KitManager::isLoaded()
void KitManager::setBinaryForKit(const FilePath &binary) void KitManager::setBinaryForKit(const FilePath &binary)
{ {
QTC_ASSERT(d, return); QTC_ASSERT(d, return);
d->setBinaryForKit(binary); d->m_binaryForKit = binary;
} }
QList<Kit *> KitManager::sortKits(const QList<Kit *> &kits) QList<Kit *> KitManager::sortKits(const QList<Kit *> &kits)