Subversion: Make settings page a value member in the plugin pimpl

No need for the indirection anymore.

Change-Id: Ib9ae5a28a02a93cb709be587f833ac2474e7d6cf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>

src/plugins/subversion/subversionplugin.cpp

@@ -320,6 +320,8 @@ private:
 
     QAction *m_menuAction = nullptr;
     bool m_submitActionTriggered = false;
+
+    SubversionSettingsPage m_settingsPage{[this] { configurationChanged(); }, &m_settings};
 };
 
 
@@ -386,8 +388,6 @@ SubversionPluginPrivate::SubversionPluginPrivate()
     using namespace Core::Constants;
     Context context(SUBVERSION_CONTEXT);
 
-    new SubversionSettingsPage([this] { configurationChanged(); }, &m_settings, this);
-
     new VcsSubmitEditorFactory(&submitParameters,
         []() { return new SubversionSubmitEditor(&submitParameters); }, this);