feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Subversion: Make settings page a value member in the plugin pimpl

Browse Source 
No need for the indirection anymore.

Change-Id: Ib9ae5a28a02a93cb709be587f833ac2474e7d6cf
Reviewed-by: Orgad Shaneh <orgads@gmail.com>
This commit is contained in:
hjk
2020-01-31 13:57:41 +01:00
parent 798b2674af
commit f29f219579
3 changed files with 4 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/plugins/subversion/settingspage.cpp
View File

@@ -102,8 +102,7 @@ void SubversionSettingsPageWidget::apply()
m_onApply();
}
SubversionSettingsPage::SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings, QObject *parent) :
Core::IOptionsPage(parent)
SubversionSettingsPage::SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings)
{
setId(VcsBase::Constants::VCS_ID_SUBVERSION);
setDisplayName(SubversionSettingsPageWidget::tr("Subversion"));

2
src/plugins/subversion/settingspage.h
View File

@@ -35,7 +35,7 @@ class SubversionSettings;
class SubversionSettingsPage final : public Core::IOptionsPage
{
public:
SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings, QObject *parent);
SubversionSettingsPage(const std::function<void()> &onApply, SubversionSettings *settings);
};
} // namespace Subversion

4
src/plugins/subversion/subversionplugin.cpp
View File

@@ -320,6 +320,8 @@ private:
QAction *m_menuAction = nullptr;
bool m_submitActionTriggered = false;
SubversionSettingsPage m_settingsPage{[this] { configurationChanged(); }, &m_settings};
};
@@ -386,8 +388,6 @@ SubversionPluginPrivate::SubversionPluginPrivate()
using namespace Core::Constants;
Context context(SUBVERSION_CONTEXT);
new SubversionSettingsPage([this] { configurationChanged(); }, &m_settings, this);
new VcsSubmitEditorFactory(&submitParameters,
[]() { return new SubversionSubmitEditor(&submitParameters); }, this);