Debugger: Remove DebuggerEngine::stateAcceptsBreakpointChanges()

Dead code since 3b5ecac238 (the end of the hybrid engine).

Change-Id: Ibb169ff657c8a88fdc52783a6a1f5b79fa0b29e5
Reviewed-by: Christian Kandeler <christian.kandeler@qt.io>
This commit is contained in:
hjk
2020-12-18 16:27:44 +01:00
parent 0edebcfa9c
commit f2f139e90e
9 changed files with 0 additions and 61 deletions

View File

@@ -2399,18 +2399,6 @@ static QByteArray multiBreakpointCommand(const char *cmdC, const Breakpoints &bp
} }
#endif #endif
bool CdbEngine::stateAcceptsBreakpointChanges() const
{
switch (state()) {
case InferiorRunOk:
case InferiorStopOk:
return true;
default:
break;
}
return false;
}
bool CdbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const bool CdbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const
{ {
if (bp.isCppBreakpoint()) { if (bp.isCppBreakpoint()) {

View File

@@ -78,9 +78,7 @@ public:
void activateFrame(int index) override; void activateFrame(int index) override;
void selectThread(const Thread &thread) override; void selectThread(const Thread &thread) override;
bool stateAcceptsBreakpointChanges() const override;
bool acceptsBreakpoint(const BreakpointParameters &params) const override; bool acceptsBreakpoint(const BreakpointParameters &params) const override;
void insertBreakpoint(const Breakpoint &bp) override; void insertBreakpoint(const Breakpoint &bp) override;
void removeBreakpoint(const Breakpoint &bp) override; void removeBreakpoint(const Breakpoint &bp) override;
void updateBreakpoint(const Breakpoint &bp) override; void updateBreakpoint(const Breakpoint &bp) override;

View File

@@ -342,7 +342,6 @@ public:
virtual Core::Context languageContext() const { return {}; } virtual Core::Context languageContext() const { return {}; }
QString displayName() const; QString displayName() const;
virtual bool stateAcceptsBreakpointChanges() const { return true; }
virtual bool acceptsBreakpoint(const BreakpointParameters &bp) const = 0; virtual bool acceptsBreakpoint(const BreakpointParameters &bp) const = 0;
virtual void insertBreakpoint(const Breakpoint &bp) = 0; virtual void insertBreakpoint(const Breakpoint &bp) = 0;
virtual void removeBreakpoint(const Breakpoint &bp) = 0; virtual void removeBreakpoint(const Breakpoint &bp) = 0;

View File

@@ -2349,20 +2349,6 @@ void GdbEngine::handleBreakCondition(const DebuggerResponse &, const Breakpoint
updateBreakpoint(bp); // Maybe there's more to do. updateBreakpoint(bp); // Maybe there's more to do.
} }
bool GdbEngine::stateAcceptsBreakpointChanges() const
{
switch (state()) {
case EngineSetupRequested:
case InferiorRunRequested:
case InferiorRunOk:
case InferiorStopRequested:
case InferiorStopOk:
return true;
default:
return false;
}
}
bool GdbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const bool GdbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const
{ {
if (runParameters().startMode == AttachCore) if (runParameters().startMode == AttachCore)

View File

@@ -185,7 +185,6 @@ private: ////////// General Interface //////////
////////// Inferior Management ////////// ////////// Inferior Management //////////
// This should be always the last call in a function. // This should be always the last call in a function.
bool stateAcceptsBreakpointChanges() const final;
bool acceptsBreakpoint(const BreakpointParameters &bp) const final; bool acceptsBreakpoint(const BreakpointParameters &bp) const final;
void insertBreakpoint(const Breakpoint &bp) final; void insertBreakpoint(const Breakpoint &bp) final;
void removeBreakpoint(const Breakpoint &bp) final; void removeBreakpoint(const Breakpoint &bp) final;

View File

@@ -482,20 +482,6 @@ void LldbEngine::selectThread(const Thread &thread)
runCommand(cmd); runCommand(cmd);
} }
bool LldbEngine::stateAcceptsBreakpointChanges() const
{
switch (state()) {
case EngineSetupRequested:
case InferiorRunRequested:
case InferiorRunOk:
case InferiorStopRequested:
case InferiorStopOk:
return true;
default:
return false;
}
}
bool LldbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const bool LldbEngine::acceptsBreakpoint(const BreakpointParameters &bp) const
{ {
if (runParameters().startMode == AttachCore) if (runParameters().startMode == AttachCore)

View File

@@ -84,7 +84,6 @@ private:
void fetchFullBacktrace(); void fetchFullBacktrace();
// This should be always the last call in a function. // This should be always the last call in a function.
bool stateAcceptsBreakpointChanges() const override;
bool acceptsBreakpoint(const BreakpointParameters &bp) const override; bool acceptsBreakpoint(const BreakpointParameters &bp) const override;
void insertBreakpoint(const Breakpoint &bp) override; void insertBreakpoint(const Breakpoint &bp) override;
void removeBreakpoint(const Breakpoint &bp) override; void removeBreakpoint(const Breakpoint &bp) override;

View File

@@ -350,18 +350,6 @@ void UvscEngine::activateFrame(int index)
reloadPeripheralRegisters(); reloadPeripheralRegisters();
} }
bool UvscEngine::stateAcceptsBreakpointChanges() const
{
switch (state()) {
case InferiorRunOk:
case InferiorStopOk:
return true;
default:
break;
}
return false;
}
bool UvscEngine::acceptsBreakpoint(const BreakpointParameters &bp) const bool UvscEngine::acceptsBreakpoint(const BreakpointParameters &bp) const
{ {
if (bp.isCppBreakpoint()) { if (bp.isCppBreakpoint()) {

View File

@@ -29,8 +29,6 @@
#include <debugger/debuggerengine.h> #include <debugger/debuggerengine.h>
namespace Utils { class FilePath; }
namespace Debugger { namespace Debugger {
namespace Internal { namespace Internal {
@@ -63,9 +61,7 @@ public:
void activateFrame(int index) final; void activateFrame(int index) final;
bool stateAcceptsBreakpointChanges() const final;
bool acceptsBreakpoint(const BreakpointParameters &params) const final; bool acceptsBreakpoint(const BreakpointParameters &params) const final;
void insertBreakpoint(const Breakpoint &bp) final; void insertBreakpoint(const Breakpoint &bp) final;
void removeBreakpoint(const Breakpoint &bp) final; void removeBreakpoint(const Breakpoint &bp) final;
void updateBreakpoint(const Breakpoint &bp) final; void updateBreakpoint(const Breakpoint &bp) final;