feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

Nim: Switch to the now hopefully final PluginPrivate pattern

Browse Source 
Change-Id: Ifffe56107974cfe9364b468dd3c3f5d69a9956d0
Reviewed-by: Christian Stenger <christian.stenger@qt.io>
This commit is contained in:
hjk
2018-03-08 11:34:08 +01:00
parent c050d916ce
commit f333a2998c
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
src/plugins/nim/nimplugin.cpp
View File

@@ -48,7 +48,7 @@ using namespace ProjectExplorer;
namespace Nim { namespace Nim {
class NimPluginRunData class NimPluginPrivate
{ {
public: public:
NimSettings settings; NimSettings settings;
@@ -62,11 +62,9 @@ public:
NimToolChainFactory toolChainFactory; NimToolChainFactory toolChainFactory;
}; };
static NimPluginRunData *m_runData = nullptr;
NimPlugin::~NimPlugin() NimPlugin::~NimPlugin()
{ {
delete m_runData; delete d;
} }
bool NimPlugin::initialize(const QStringList &arguments, QString *errorMessage) bool NimPlugin::initialize(const QStringList &arguments, QString *errorMessage)
@@ -74,7 +72,7 @@ bool NimPlugin::initialize(const QStringList &arguments, QString *errorMessage)
Q_UNUSED(arguments) Q_UNUSED(arguments)
Q_UNUSED(errorMessage) Q_UNUSED(errorMessage)
m_runData = new NimPluginRunData; d = new NimPluginPrivate;
ToolChainManager::registerLanguage(Constants::C_NIMLANGUAGE_ID, Constants::C_NIMLANGUAGE_NAME); ToolChainManager::registerLanguage(Constants::C_NIMLANGUAGE_ID, Constants::C_NIMLANGUAGE_NAME);

5
src/plugins/nim/nimplugin.h
View File

@@ -46,6 +46,9 @@ private slots:
void testNimParser_data(); void testNimParser_data();
void testNimParser(); void testNimParser();
#endif #endif
private:
class NimPluginPrivate *d = nullptr;
}; };
} } // Nim