feedc0de/qt-creator
1
0
Fork 0
forked from qt-creator/qt-creator
Code Pull Requests Activity

QmlDesigner: use list initialization

Browse Source 
Change-Id: Iecc075d82c5b26589a6201a3b1adb04f59c92db0
Reviewed-by: Thomas Hartmann <Thomas.Hartmann@theqtcompany.com>
This commit is contained in:
Tim Jenssen
2016-10-25 08:56:45 +02:00
committed by Tim Jenssen
parent 791e8af5dd
commit f35d71478d
2 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files

52
src/plugins/qmldesigner/designercore/model/modeltotextmerger.cpp
View File

@@ -85,7 +85,7 @@ void ModelToTextMerger::propertiesChanged(const QList<AbstractProperty>& propert
ModelNode containedModelNode; ModelNode containedModelNode;
const int indentDepth = m_rewriterView->textModifier()->indentDepth(); const int indentDepth = m_rewriterView->textModifier()->indentDepth();
const QString propertyTextValue = QmlTextGenerator(getPropertyOrder(), const QString propertyTextValue = QmlTextGenerator(propertyOrder(),
indentDepth)(property); indentDepth)(property);
switch (propertyChange) { switch (propertyChange) {
@@ -162,14 +162,14 @@ void ModelToTextMerger::nodeReparented(const ModelNode &node, const NodeAbstract
switch (propertyChange) { switch (propertyChange) {
case AbstractView::PropertiesAdded: case AbstractView::PropertiesAdded:
schedule(new AddPropertyRewriteAction(newPropertyParent, schedule(new AddPropertyRewriteAction(newPropertyParent,
QmlTextGenerator(getPropertyOrder())(node), QmlTextGenerator(propertyOrder())(node),
propertyType(newPropertyParent), propertyType(newPropertyParent),
node)); node));
break; break;
case AbstractView::NoAdditionalChanges: case AbstractView::NoAdditionalChanges:
schedule(new ChangePropertyRewriteAction(newPropertyParent, schedule(new ChangePropertyRewriteAction(newPropertyParent,
QmlTextGenerator(getPropertyOrder())(node), QmlTextGenerator(propertyOrder())(node),
propertyType(newPropertyParent), propertyType(newPropertyParent),
node)); node));
break; break;
@@ -212,7 +212,7 @@ void ModelToTextMerger::applyChanges()
return; return;
dumpRewriteActions(QStringLiteral("Before compression")); dumpRewriteActions(QStringLiteral("Before compression"));
RewriteActionCompressor compress(getPropertyOrder()); RewriteActionCompressor compress(propertyOrder());
compress(m_rewriteActions); compress(m_rewriteActions);
dumpRewriteActions(QStringLiteral("After compression")); dumpRewriteActions(QStringLiteral("After compression"));
@@ -241,7 +241,7 @@ void ModelToTextMerger::applyChanges()
ModelNodePositionRecalculator positionRecalculator(m_rewriterView->positionStorage(), m_rewriterView->positionStorage()->modelNodes()); ModelNodePositionRecalculator positionRecalculator(m_rewriterView->positionStorage(), m_rewriterView->positionStorage()->modelNodes());
positionRecalculator.connectTo(textModifier); positionRecalculator.connectTo(textModifier);
QmlRefactoring refactoring(tmpDocument, *textModifier, getPropertyOrder()); QmlRefactoring refactoring(tmpDocument, *textModifier, propertyOrder());
textModifier->deactivateChangeSignals(); textModifier->deactivateChangeSignals();
textModifier->startGroup(); textModifier->startGroup();
@@ -348,31 +348,27 @@ QmlRefactoring::PropertyType ModelToTextMerger::propertyType(const AbstractPrope
return (QmlRefactoring::PropertyType) -1; return (QmlRefactoring::PropertyType) -1;
} }
PropertyNameList ModelToTextMerger::m_propertyOrder; PropertyNameList ModelToTextMerger::propertyOrder()
PropertyNameList ModelToTextMerger::getPropertyOrder()
{ {
if (m_propertyOrder.isEmpty()) { static const PropertyNameList properties = {
m_propertyOrder PropertyName("id"),
<< PropertyName("id") PropertyName("name"),
<< PropertyName("name") PropertyName("target"),
<< PropertyName("target") PropertyName("property"),
<< PropertyName("property") PropertyName("x"),
<< PropertyName("x") PropertyName("y"),
<< PropertyName("y") PropertyName("width"),
<< PropertyName("width") PropertyName("height"),
<< PropertyName("height") PropertyName("position"),
<< PropertyName("position") PropertyName("color"),
<< PropertyName("color") PropertyName("radius"),
<< PropertyName("radius") PropertyName("text"),
<< PropertyName("text") PropertyName(),
<< PropertyName() PropertyName("states"),
<< PropertyName("states") PropertyName("transitions")
<< PropertyName("transitions") };
;
}
return m_propertyOrder; return properties;
} }
bool ModelToTextMerger::isInHierarchy(const AbstractProperty &property) { bool ModelToTextMerger::isInHierarchy(const AbstractProperty &property) {

3
src/plugins/qmldesigner/designercore/model/modeltotextmerger.h
View File

@@ -37,7 +37,6 @@ namespace Internal {
class ModelToTextMerger class ModelToTextMerger
{ {
typedef AbstractView::PropertyChangeFlags PropertyChangeFlags; typedef AbstractView::PropertyChangeFlags PropertyChangeFlags;
static PropertyNameList m_propertyOrder;
public: public:
ModelToTextMerger(RewriterView *reWriterView); ModelToTextMerger(RewriterView *reWriterView);
@@ -75,7 +74,7 @@ protected:
{ return m_rewriteActions; } { return m_rewriteActions; }
static QmlDesigner::QmlRefactoring::PropertyType propertyType(const AbstractProperty &property, const QString &textValue = QString()); static QmlDesigner::QmlRefactoring::PropertyType propertyType(const AbstractProperty &property, const QString &textValue = QString());
static PropertyNameList getPropertyOrder(); static PropertyNameList propertyOrder();
static bool isInHierarchy(const AbstractProperty &property); static bool isInHierarchy(const AbstractProperty &property);